-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Script improvements #5471
Merged
Merged
CI Script improvements #5471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results106 files +10 106 suites +10 1m 20s ⏱️ +10s Results for commit c687252. ± Comparison against base commit fbc3b15. This pull request removes 8 and adds 24 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
michaelkaye
force-pushed
the
michaelk/ci_script_improvements
branch
from
March 10, 2022 10:24
63cbe43
to
029ccfa
Compare
michaelkaye
requested review from
a team and
ariskotsomitopoulos
and removed request for
a team
March 10, 2022 12:23
.github/workflows/nightly.yml
Outdated
@@ -308,6 +308,7 @@ jobs: | |||
failure_screenshots/ | |||
|
|||
codecov-units: | |||
name: Unit tests with codecoverage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code coverage*
ariskotsomitopoulos
approved these changes
Mar 16, 2022
michaelkaye
commented
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
If a test fails to run, ensure the renderer prints a suitable message
Format nightly run data in colour to be more obvious when failures occur.
Upload synapse homeserver log after run for diagnosis.Add names to all runs
Motivation and context
General improvement to the test scripts to make it easier to understand what's going on.
Synapse homeserver logging has been removed in favour of
Screenshots / GIFs
Tests
Tested devices
Checklist