Use attributed string whitespace for URL previews. #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove heightForCellData:withMaximumWidth: from the various TextMsgBubbleCell subclasses. Use the bubble cell data's available width when sizing URL previews and update the defaultAvailableWidth and reducedWidthThreshold accordingly.
…te that it doesn't affect the attributedTextMessage.
…omponent. Stop breaking up the bubble data for links now that vertical whitespace is added.
Reset all cell data when this setting is changed to force a refresh. Rename `hasClosedPreview(from:)` to `shouldShowPreview(for:)` for clarity and potentially adding more rules at a later date.
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/5BbqiM |
SBiOSoftWhare
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4896, depends on matrix-org/matrix-ios-kit#916. This PR does the following:
urlPreviewDataandshowURLPreviewproperties fromRoomBubbleCellDatatoMXKRoomBubbleComponentso that previews can be managed per event rather than per cell.heightForCellData:withMaximumWidth:.invalidateTextLayoutinstead of clearing the cell data's attributed string when the layout changes.refreshAttributedTextMessagetomakeAttributedStringas it only creates the string but doesn't assign it.