This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
Use attributed string whitespace for URL previews. #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
commented
Sep 28, 2021
…roperties section.
| // limitations under the License. | ||
| // | ||
|
|
||
| @protocol MXKURLPreviewDataProtocol <NSObject> |
There was a problem hiding this comment.
We can now make classes and protocol in Swift in the Kit
SBiOSoftWhare
approved these changes
Sep 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-ios#4896 along side the PR element-hq/element-ios#4924. This PR makes 2 changes:
Adds
invalidateTextLayoutmethod toMXKRoomBubbleCellDataand replaces all occurrences of setting the attributed string to nil with this method. This was done to make updating the cell's layout more obvious. Any tweaks to the docs/naming totally welcome 🙂Adds
urlPreviewDataandshowURLPreviewproperties toMXKBubbleComponentfor use from Element (they do nothing by theirselves in Kit). There is one question/comment inline about how this was done.