Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a flickering issue when the timeline datasource is reloaded. #7528

Merged
merged 1 commit into from
May 3, 2023

Conversation

nimau
Copy link
Contributor

@nimau nimau commented Apr 28, 2023

This PR fixes #7523

When the MXKRoomDataSource was reloaded, the tableView was refreshed immediately after the reset, showing a blank screen.
With this fix, the tableView is refreshed at the end of the reload method, which prevents a blank screen from appearing.

The MXKRoomDataSource resetNotifying method no longer seems necessary with this fix, as the original reset method was only called from:

  • MXKRoomDataSource::reload
  • MXKRoomDataSource::destroy: in this case its delegate is already nil

@nimau nimau requested a review from stefanceriu April 28, 2023 14:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (c9e9bd0) 12.37% compared to head (bc3c1b2) 12.37%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7528      +/-   ##
===========================================
- Coverage    12.37%   12.37%   -0.01%     
===========================================
  Files         1646     1646              
  Lines       163364   163361       -3     
  Branches     67078    67077       -1     
===========================================
- Hits         20218    20214       -4     
- Misses      142482   142484       +2     
+ Partials       664      663       -1     
Flag Coverage Δ
uitests 55.06% <ø> (ø)
unittests 6.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rify/SAS/Views/VerifyEmojiCollectionViewCell.swift 0.00% <0.00%> (ø)
.../Modules/MatrixKit/Models/Room/MXKRoomDataSource.m 12.76% <0.00%> (-0.13%) ⬇️
...MatrixKit/Utils/EventFormatter/MXKEventFormatter.m 16.94% <0.00%> (ø)
.../SetPinCode/SetPinCoordinatorBridgePresenter.swift 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ¯_(ツ)_/¯

@nimau nimau merged commit 379e8e2 into develop May 3, 2023
@nimau nimau deleted the nimau/7523_timeline_reload branch May 3, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blink of the room timeline with a blank screen
2 participants