Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a flickering issue when the timeline datasource is reloaded. #7528

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix a flickering issue when the timeline datasource is reloaded. #7528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions Riot/Modules/MatrixKit/Models/Room/MXKRoomDataSource.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,6 @@ - (void)limitMemoryUsage:(NSInteger)maxBubbleNb
}

- (void)reset
{
[self resetNotifying:YES];
}

- (void)resetNotifying:(BOOL)notify
{
if (roomDidFlushDataNotificationObserver)
{
Expand Down Expand Up @@ -556,12 +551,6 @@ - (void)resetNotifying:(BOOL)notify
}

_serverSyncEventCount = 0;

// Notify the delegate to reload its tableview
if (notify && self.delegate)
{
[self.delegate dataSource:self didCellChange:nil];
}
}

- (void)reload
Expand All @@ -575,10 +564,16 @@ - (void)reloadNotifying:(BOOL)notify

[self setState:MXKDataSourceStatePreparing];

[self resetNotifying:notify];
[self reset];

// Reload
[self didMXSessionStateChange];

// Notify the delegate to refresh the tableview
if (notify && self.delegate)
{
[self.delegate dataSource:self didCellChange:nil];
}
}

- (void)destroy
Expand Down
1 change: 1 addition & 0 deletions changelog.d/7523.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a flickering issue when the timeline datasource is reloaded.