Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSC2432: Alias semantics #12337

Closed
8 tasks done
richvdh opened this issue Feb 12, 2020 · 6 comments
Closed
8 tasks done

Implement MSC2432: Alias semantics #12337

richvdh opened this issue Feb 12, 2020 · 6 comments
Assignees
@bwindels
Labels
A-Aliases P1 T-Enhancement

Comments

@richvdh
Copy link
Member

richvdh commented Feb 12, 2020 •
edited by bwindels
Loading

We've got yet another idea for how to implement alias semantics, documented in https://docs.google.com/document/d/1NNDkobiFLeUkJtyj0H6qvKIedgvIkZnFKo78-03cGEk and MSC2432.

Here are the things I think need doing in Riot (et al):

  • stop formatting m.room.aliases events specially in timelines
  • stop considering m.room.aliases events for room names
  • Update Room Settings UI to:
    • remove display of m.room.aliases, since they are now meaningless
    • let users see all the aliases for the room on the local server
    • hide local aliases behind an ‘advanced’ disclosure or something, just to help hide obnoxious local ones by default unless you’re really hunting for them
    • let users see the current "main" and "alternative" aliases from the m.room.canonical_aliases list
    • let mods twiddle the list of advertised aliases and send updated canonical_aliases events
@richvdh
Copy link
Member Author

richvdh commented Feb 12, 2020

The synapse side of this is matrix-org/synapse#6898.

@turt2live turt2live changed the title Implement MSC2432 Implement MSC2432: Alias semantics Feb 12, 2020
@jryans
Copy link
Collaborator

jryans commented Feb 18, 2020

We'll start with updating the local aliases as a subset of this in #12408.

This was referenced Feb 19, 2020
Closed
Closed
@bwindels
Copy link
Contributor

Already started working on editing alt_aliases on branch bwindels/altaliases fwiw. Parked it now as it is not priority.

This was referenced Mar 9, 2020
Merged
Merged
@bwindels bwindels self-assigned this Mar 9, 2020
@bwindels bwindels mentioned this issue Mar 9, 2020
Merged
@bwindels
Copy link
Contributor

bwindels commented Mar 9, 2020 •
edited
Loading

PRs are out for all of the above checkboxes, but doing a search for m.room.aliases in the code shows still quite a few occurrences. Need to go back to cross-signing now, but we might want to clean that up at some point.

@bwindels bwindels mentioned this issue Mar 10, 2020
Closed
7 tasks
@bwindels
Copy link
Contributor

Filed #12680 to track the remaining cleanup, closing this.

This was referenced Mar 11, 2020
Closed
Closed
@richvdh
Copy link
Member Author

richvdh commented Mar 17, 2020

\o/ thanks bruno!

@richvdh richvdh mentioned this issue Mar 20, 2020
Closed
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@florianduros
TAC: Fix hover state when expanded (#12337)
e309410 
* Fix TAC hover state

* Add playwright test

* Update playwright snapshot after last compound style changes
JohnSimonsen pushed a commit to verji/element-web-v2 that referenced this issue Dec 20, 2024
@thoraj @florianduros
@dbkr @richvdh @RiotRobot @robintown
Get upstream changes via verji#develop (element-hq#13)
de3a9bc 
* Update `@vector-im/compound-design-tokens` in package.json (element-hq#12339)

* Change 'type' prop on badges to 'forceDot' (element-hq#12327)

* Change 'type' prop on badges tio 'forceDot'

Which, hopefully, better represents what it actually does. Tidies
up some of the logic.

Split out from matrix-org/matrix-react-sdk#12254

* Missed a file

* More comments

* Oops, there is no count here.

* Back out the logic refactor of StatelessNotificationBadge

because it was also updating the logic for mark as unread badges and
rewriting the ternary to the previous logic would be quite complex.

* Fix doc comment

Co-authored-by: Richard van der Hoff <[email protected]>

* Clarify doc on displaying the count

* Update doc for the forceDot param here too.

---------

Co-authored-by: Richard van der Hoff <[email protected]>

* [Backport staging] Update `@vector-im/compound-design-tokens` in package.json (element-hq#12340)

(cherry picked from commit e3ba643)

Co-authored-by: Florian Duros <[email protected]>

* Fix the image view (element-hq#12341)

* TAC: Fix hover state when expanded (element-hq#12337)

* Fix TAC hover state

* Add playwright test

* Update playwright snapshot after last compound style changes

* v3.95.0-rc.0

* v3.95.0

* Reset matrix-js-sdk back to develop branch

* TAC: Order rooms by most recent after notification level (element-hq#12329)

* Order room by thread timestamp

* Fix key errors in test

* Update jest snapshots

* Update snapshots

* Rename alpha/beta to numbers

* Add playwright test

* Replace forceCount prop with hideIfDot (element-hq#12344)

This replaces the `forceCount` prop on room badge components with
`hideIfDot` which hopefully gives a better idea of what it does,
since forceCount did not really force a count. Also remove the
prop where it was just passing the default value anyway.

---------

Co-authored-by: Florian Duros <[email protected]>
Co-authored-by: David Baker <[email protected]>
Co-authored-by: Richard van der Hoff <[email protected]>
Co-authored-by: ElementRobot <[email protected]>
Co-authored-by: Robin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bwindels bwindels

Labels
A-Aliases P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bwindels @jryans @richvdh