Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goneb room is in the room directory even though it doesn't have an alias? #12698

Closed
aaronraimist opened this issue Mar 12, 2020 · 4 comments · Fixed by matrix-org/matrix-react-sdk#4210
Assignees

Comments

@aaronraimist
Copy link
Collaborator

The goneb room is in the matrix.org room directory but is unjoinable because there is no alias listed so clicking on it gives a "No known servers" error since it is trying to join by room ID.

@bwindels
Copy link
Contributor

This looks like fallout from the recent alias changes in #12337

@bwindels
Copy link
Contributor

#neb:matrix.org might want to consider setting a canonical alias. m.room.aliases have been deprecated by MSC2432 and Synapse doesn't seem to return any local aliases any more to prevent alias spam. I've filed matrix-org/synapse#7069 as well to see if we can improve anything on the server side as well.

@bwindels
Copy link
Contributor

Once we decide if and how to handle this on the synapse side, there might be some more work left on the riot side, so leaving it open for now, but as the fix is easy (adding a canonical alias) I'll deprioritize this.

@bwindels
Copy link
Contributor

Turns out we can also improve the situation on the riot side by passing the currently selected server in the room directory to the join command. PR is out for that.

t3chguy added a commit that referenced this issue Oct 17, 2024
* Extract SearchScope and SearchInfo into Searching

Signed-off-by: Michael Telatynski <[email protected]>

* delint

Signed-off-by: Michael Telatynski <[email protected]>

* delint

Signed-off-by: Michael Telatynski <[email protected]>

* Fix test

Signed-off-by: Michael Telatynski <[email protected]>

* Comments

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants