-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n can still go wrong #12591
Comments
If it's caused by missing cache, one way to prevent this would be to make all of the assets available offline through our service worker. This would also preload icons, etc. The hardest part probably being creating a list of all of our assets (during build) without causing a maintenance headache, although we might be able to get rid of the content hashes with this approach. |
There's https://www.npmjs.com/package/serviceworker-webpack-plugin to auto-populate it with a blacklist |
Probably best to keep the content hashes though, in case the browser removes your cache but not your (outdated) service worker, you'd end up rerequesting but getting the asset for a newer version. |
I'm getting reports on this on app.element.io (i.e. not to do with cachebusting going wrong, unless it happened to coincide with a release getting pushed)? |
@ara4n And BTW, this is me from the email report on this issue. |
We had to pull it back out due to other issues it caused: #15352 |
Got it twice this week, once on Firefox Stable and once on Firefox Nightly, both times on app.element.io, both times when starting Firefox. In both cases, a reload fixed the issue. |
This happens to me constantly as well on Firefox. |
Since the only actual reports on this issue are of this occurring in Firefox, closing this as a duplicate of #9422 |
* Keep dialog glass border on narrow screens It got pushed off the edge and eventually disappeared on narrow screens, so force it to always be present. * Update screenshot
Resurgence of #10859
Possible cause being #10965
The text was updated successfully, but these errors were encountered: