Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n can still go wrong #12591

Closed
turt2live opened this issue Mar 2, 2020 · 9 comments · Fixed by #15196
Closed

i18n can still go wrong #12591

turt2live opened this issue Mar 2, 2020 · 9 comments · Fixed by #15196

Comments

@turt2live
Copy link
Member

Resurgence of #10859

Possible cause being #10965

@bwindels
Copy link
Contributor

bwindels commented Mar 6, 2020

If it's caused by missing cache, one way to prevent this would be to make all of the assets available offline through our service worker. This would also preload icons, etc. The hardest part probably being creating a list of all of our assets (during build) without causing a maintenance headache, although we might be able to get rid of the content hashes with this approach.

@t3chguy
Copy link
Member

t3chguy commented Mar 6, 2020

There's https://www.npmjs.com/package/serviceworker-webpack-plugin to auto-populate it with a blacklist

@bwindels
Copy link
Contributor

bwindels commented Mar 6, 2020

Probably best to keep the content hashes though, in case the browser removes your cache but not your (outdated) service worker, you'd end up rerequesting but getting the asset for a newer version.

@ara4n
Copy link
Member

ara4n commented Sep 7, 2020

I'm getting reports on this on app.element.io (i.e. not to do with cachebusting going wrong, unless it happened to coincide with a release getting pushed)?

@mcepl
Copy link

mcepl commented Sep 7, 2020

@ara4n And BTW, this is me from the email report on this issue.

@t3chguy
Copy link
Member

t3chguy commented Oct 1, 2020

We had to pull it back out due to other issues it caused: #15352

@Yoric
Copy link
Contributor

Yoric commented Nov 28, 2020

Got it twice this week, once on Firefox Stable and once on Firefox Nightly, both times on app.element.io, both times when starting Firefox. In both cases, a reload fixed the issue.

@lutoma
Copy link

lutoma commented Feb 4, 2021

This happens to me constantly as well on Firefox.

@jryans jryans added I18n and removed defect labels Mar 4, 2021
@robintown
Copy link
Member

Since the only actual reports on this issue are of this occurring in Firefox, closing this as a duplicate of #9422

t3chguy pushed a commit that referenced this issue Oct 17, 2024
* Keep dialog glass border on narrow screens

It got pushed off the edge and eventually disappeared on narrow
screens, so force it to always be present.

* Update screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants