Replace dummy sw.js with pre-caching and runtime-caching workbox SW #15196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3chguy
force-pushed
the
t3chguy/fix/12591
branch
from
f27090b to
c76a5f2
Compare
So many words. |
turt2live
requested changes
Sep 18, 2020
Comment on lines
-58
to
-67
| <!-- Legacy supporting Prefetch images --> | ||
| <img src="<%= require('matrix-react-sdk/res/img/warning.svg') %>" width="24" height="23" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/e2e/warning.svg') %>" width="24" height="23" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/feather-customised/warning-triangle.svg') %>" width="24" height="23" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/format/bold.svg') %>" width="25" height="22" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/format/code.svg') %>" width="25" height="22" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/format/italics.svg') %>" width="25" height="22" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/format/quote.svg') %>" width="25" height="22" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
| <img src="<%= require('matrix-react-sdk/res/img/format/strikethrough.svg') %>" width="25" height="22" style="visibility: hidden; position: absolute; top: 0px; left: 0px;"/> | ||
|
|
There was a problem hiding this comment.
most of these are required so the user actually sees an icon when they go offline, such as the warning triangle. The composer ones are so there isn't a delay when showing the formatting bar the first time
There was a problem hiding this comment.
Yup, now handled by the service worker's prefetch
There was a problem hiding this comment.
was it committed? I'm not seeing it
There was a problem hiding this comment.
It is the behaviour of workbox to precache all webpack outputs which match criteria like the above
There was a problem hiding this comment.
ah, neat. Would be good to include that in the PR description :)
turt2live
approved these changes
Sep 18, 2020
|
Blocking until after RC as it is risky |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service Worker
Fixes #12591