Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: Verification gets stuck if both users hit "verify by emoji" #26723

Closed
richvdh opened this issue Dec 11, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#4004
Closed

Element-R: Verification gets stuck if both users hit "verify by emoji" #26723

richvdh opened this issue Dec 11, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#4004
Assignees
@uhoreg
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Dec 11, 2023

If both users hit "Verify with emoji" at the same time, there is a race resolution algorithm which says:

If Alice’s and Bob’s clients both send an m.key.verification.start message, and both specify the same verification method, then the m.key.verification.start message sent by the user whose ID is the lexicographically largest user ID should be ignored, and the situation should be treated the same as if only the user with the lexicographically smallest user ID had sent the m.key.verification.start message.

... which I think means that the loser needs to send an m.key.verification.accept message. This doesn't seem to happen; instead both sides get stuck with a spinner.
@richvdh richvdh added the A-Element-R Issues affecting the port of Element's crypto layer to Rust label Dec 11, 2023
@t3chguy t3chguy mentioned this issue Dec 11, 2023
Merged
@richvdh
Copy link
Member Author

richvdh commented Dec 11, 2023

See matrix-org/matrix-react-sdk#12021 for a playwright test that has to work around this bug.

@MidhunSureshR MidhunSureshR added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 13, 2023
@uhoreg uhoreg self-assigned this Dec 28, 2023
@uhoreg uhoreg mentioned this issue Jan 12, 2024
Merged
3 tasks
@richvdh
Copy link
Member Author

richvdh commented Feb 3, 2024

@uhoreg: now that this is fixed, it would be nice to remove the workaround mentioned in the summary in matrix-org/matrix-react-sdk#12021

richvdh added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 3, 2024
@richvdh
Remove redundant workaround in playwright test
113ed47 
This was element-hq/element-web#26723, which is fixed.
@richvdh richvdh mentioned this issue Apr 3, 2024
Merged
@richvdh
Copy link
Member Author

richvdh commented Apr 3, 2024

@uhoreg: now that this is fixed, it would be nice to remove the workaround mentioned in the summary in matrix-org/matrix-react-sdk#12021

Done in matrix-org/matrix-react-sdk#12390

github-merge-queue bot pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 3, 2024
@richvdh
Remove redundant workaround in playwright test (#12390)
3de8de5 
This was element-hq/element-web#26723, which is fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uhoreg uhoreg

Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround Z-Labs
Projects
None yet
Milestone
No milestone
3 participants
@uhoreg @richvdh @MidhunSureshR