This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 828
Migrate remaining crypto tests from Cypress to Playwright #12021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Dec 8, 2023
… t3chguy/playwright/convert-36
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
florianduros
approved these changes
Dec 12, 2023
Ideally we would have conditionally expected the test to fail when we're running element with rust crypto: test.fail(testInfo.project.name === 'Rust Crypto', 'See https://github.com/vector-im/element-web/issues/26723'); |
@MidhunSureshR that wouldn't catch a regression in the rust crypto stack which made it fail outside of the edge case though. |
Sorry, I don't think I understand? |
@MidhunSureshR if we allowed the test to fail, and rust crypto broke verification outside of the edge case I isolated, then we wouldn't know as the test was expected to fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/vector-im/wat-internal/issues/37
Changing from
@alice
to@user
caused Rust Crypto to fail with element-hq/element-web#26723 - worked around by changing@bot_XXXX
to@zzz_XXXX
This change is marked as an internal change (Task), so will not be included in the changelog.