Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Migrate remaining crypto tests from Cypress to Playwright #12021

Merged
merged 12 commits into from
Dec 12, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 8, 2023

For https://github.com/vector-im/wat-internal/issues/37

Changing from @alice to @user caused Rust Crypto to fail with element-hq/element-web#26723 - worked around by changing @bot_XXXX to @zzz_XXXX


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Dec 8, 2023
@t3chguy t3chguy self-assigned this Dec 8, 2023
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy added this pull request to the merge queue Dec 12, 2023
Merged via the queue into develop with commit 5104d53 Dec 12, 2023
24 checks passed
@t3chguy t3chguy deleted the t3chguy/playwright/convert-36 branch December 12, 2023 09:16
@MidhunSureshR
Copy link
Contributor

Changing from @alice to @user caused Rust Crypto to fail with element-hq/element-web#26723 - worked around by changing @bot_XXXX to @zzz_XXXX

Ideally we would have conditionally expected the test to fail when we're running element with rust crypto:

test.fail(testInfo.project.name === 'Rust Crypto', 'See https://github.com/vector-im/element-web/issues/26723');

@t3chguy
Copy link
Member Author

t3chguy commented Dec 12, 2023

@MidhunSureshR that wouldn't catch a regression in the rust crypto stack which made it fail outside of the edge case though.

@MidhunSureshR
Copy link
Contributor

Sorry, I don't think I understand?

@t3chguy
Copy link
Member Author

t3chguy commented Dec 12, 2023

@MidhunSureshR if we allowed the test to fail, and rust crypto broke verification outside of the edge case I isolated, then we wouldn't know as the test was expected to fail.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants