Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align CTA button on login flow. #825

Closed
bmarty opened this issue Jul 7, 2023 · 5 comments · Fixed by #2212
Closed

Align CTA button on login flow. #825

bmarty opened this issue Jul 7, 2023 · 5 comments · Fixed by #2212
Labels
good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users

Comments

@bmarty
Copy link
Member

bmarty commented Jul 7, 2023

To avoid flickering effect:

CTA Moving

Should be more aligned:

image
@bmarty bmarty added S-Tolerable Low/no impact on users O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 7, 2023
@bmarty bmarty added the good first issue Good for newcomers label Jul 24, 2023
@kittykat kittykat added the Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ label Sep 8, 2023
@ankitkumar1302
Copy link

Hello, @bmarty
I would like to work on it (#825), I am a newbie should you tell me about it or guide me and
I already set up the whole project and ran it on my physical device. now what next..?

@ankitkumar1302
Copy link

Hello

@Aditya8840
Copy link

Hi, I would like to work on this issue

@Umair-Siddique
Copy link

Hi can you please assign this issue to me

I'm on it

@bmarty
Copy link
Member Author

bmarty commented Nov 30, 2023 •
edited
Loading

Thanks @Umair-Siddique ! I prefer not assigning issue to external contributor, but thanks for letting us know. Expecting a nice PR from you!

@surakin surakin mentioned this issue Jan 11, 2024
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ O-Occasional Affects or can be seen by some users regularly or most users rarely S-Tolerable Low/no impact on users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aligned CTA button on login flow surakin/element-x-android
5 participants
@kittykat @bmarty @Aditya8840 @ankitkumar1302 @Umair-Siddique