Aligned CTA button on login flow

[surakin]

Adjusted the login flow buttons a little bit
They were slightly smaller on the onboarding page so I used that everywhere

Type of change

• Feature
• Bugfix
• Technical
• Other : cosmetic

Content

Aligned the button on the login flow as requested

Motivation and context

Fixes #825

Screenshots / GIFs

Tests

Play around the initial flow

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[frebib]

Text doesn't fit the button here now

[frebib]

Spacing is off here too

[surakin]

Should I try to fix these? It's not like they are part of any enabled functionality yet 🤔

[jmartinesp]

Thanks for the PR! IMO, the new alignment and size of the buttons looks better, somehow making them a bit smaller than the rest of the content makes them stand out more. However, any change in designs like this must be approved by our design team, since it's part of our effort to keep designs consistent across platforms. What do you think @amshakal ?

Also, I think @bmarty already did some work in this area, so maybe he knows better than me what decision we took about this (if we did).

On the other hand, about the 'broken' screenshots: I'd say we can make an exception for the onboarding screen and not follow this positioning of the 'Continue' button since it's the very first one if I'm not mistaken. As for the issue with the 'allow biometric' button text being cut, maybe we could change it from 'Allow biometric authentication' to 'Allow biometric unlock' or 'Use biometric authentication' so it fits.

Anyway, let's see what the design team thinks about these changes before discussing any changes.

[jmartinesp]

@surakin sorry for the delay, but our design team is on holiday until next week 😓

[surakin]

No rush :) This can wait

[amshakal]

Heya! Thanks for contributing. :)
The buttons position and width looks good. I am happy to approve these suggestions from the design side.

[jmartinesp]

Thanks @amshakal ! @surakin can you fix the conflicts?

[surakin]

That should do!

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5202f73) 70.07% compared to head (3cc5716) 71.23%.
Report is 19 commits behind head on develop.

Files	Patch %	Lines
...in/impl/screens/loginpassword/LoginPasswordView.kt	76.92%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2212      +/-   ##
===========================================
+ Coverage    70.07%   71.23%   +1.15%     
===========================================
  Files         1352     1352              
  Lines        33243    31857    -1386     
  Branches      6875     6322     -553     
===========================================
- Hits         23296    22692     -604     
+ Misses        6633     5856     -777     
+ Partials      3314     3309       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.