Sync Strings #2765
Sync Strings #2765
Conversation
ElementBot
commented
Apr 29, 2024
ElementBot
commented
- Update Strings from Localazy
|
|
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2765 +/- ##
========================================
Coverage 73.60% 73.60%
========================================
Files 1504 1504
Lines 36058 36058
Branches 6957 6957
========================================
Hits 26539 26539
Misses 5870 5870
Partials 3649 3649 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
The 3rd line in the title and the new button make this screen too cramped in small displays in German.
There was a problem hiding this comment.
Is there a way I can access the screenshots to understand what the problem is?
There was a problem hiding this comment.
Opening the link above and tapping on 'load diff'. It will probably take some time to scroll to the right file because the PR diff is quite large.
There was a problem hiding this comment.
In any case, here's a screenshot of the diff:
There was a problem hiding this comment.
Also, it seems like the meaning of the 2nd button is completely lost, I just realised that...
There was a problem hiding this comment.
Yes, I think we may want buttons to be displayed on 2 lines if necessary.
But note that screenshot are recorder with a rather small screen device. It will less happen IRL. On the other side, user can increase the font size and in this case, it can also be broken.
There was a problem hiding this comment.
Yes, I think we may want buttons to be displayed on 2 lines if necessary.
I guess we could do that for text only buttons, but I wouldn't do it for outlined/filled buttons. In this case, I think the best solution is to not try to directly translate the 'forgot your password?' action and use something that fits better, but that's just my opinion.
There was a problem hiding this comment.
It's a bit weird that the avatar option was the only one using the Raum- prefix and now it's the only one not using it.
|
@VolkerJunginger there are a couple of issues with the German translations, see my comments above. |
| @@ -30,7 +30,7 @@ | |||
| <string name="state_event_room_join_by_you">"Vous avez rejoint le salon"</string> | |||
| <string name="state_event_room_knock">"%1$s a demandé à rejoindre"</string> | |||
| <string name="state_event_room_knock_accepted">"%1$s a autorisé %2$s à rejoindre"</string> | |||
| <string name="state_event_room_knock_accepted_by_you">"%1$s vous a autorisé à rejoindre"</string> | |||
| <string name="state_event_room_knock_accepted_by_you">"Vous avez autoriser %1$s à joindre le salon"</string> | |||
There was a problem hiding this comment.
Note: I'll fix the typo on Localazy.
|
OK, there is nothing blocking, let's merge and fix any issue later. |
