Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rich text editor fails parsing lists #2303

Closed
stefanceriu opened this issue Jan 6, 2024 · 2 comments · Fixed by #2327
Closed

Rich text editor fails parsing lists #2303

stefanceriu opened this issue Jan 6, 2024 · 2 comments · Fixed by #2327
Labels
A-Composer A-Rich-Text-Editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@stefanceriu
Copy link
Member

stefanceriu commented Jan 6, 2024 •
edited
Loading

Original report here https://github.com/element-hq/element-x-ios-rageshakes/issues/1289

It happens if you type a message like:
Djdjs
1. Jdjdj
2. Jdjdj

So i think 2 line returns make the trick

The composer remains empty and then we fatal error when sending the message

ElementX/RoomScreenViewModel.swift:466: Fatal error: This message should never be empty
@stefanceriu stefanceriu added A-Composer T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Rich-Text-Editor labels Jan 6, 2024
@stefanceriu
Copy link
Member Author

Update: this only happens when the rich text editor is disabled i.e. markdown mode

@stefanceriu
Copy link
Member Author

Same as #2303

@Velin92 Velin92 mentioned this issue Jan 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Composer A-Rich-Text-Editor O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reverting RTE to use SDK markdown when in markdown mode element-hq/element-x-ios
1 participant
@stefanceriu