Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting RTE to use SDK markdown when in markdown mode #2327

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 12, 2024

Also added a way to prevent user suggestions to display when RTE is disabled

fixes #2303
fixes #2265

@Velin92 Velin92 requested a review from a team as a code owner January 12, 2024 10:51
@Velin92 Velin92 requested review from pixlwave and stefanceriu and removed request for a team January 12, 2024 10:51
Copy link

github-actions bot commented Jan 12, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 5d44960

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (21fa5d1) 72.64% compared to head (7d776f0) 72.53%.
Report is 2 commits behind head on develop.

❗ Current head 7d776f0 differs from pull request most recent head 5d44960. Consider uploading reports for the commit 5d44960 to get more accurate results

Files Patch % Lines
...rces/Services/Timeline/TimelineProxyProtocol.swift 0.00% 6 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 3 Missing ⚠️
...ources/Services/Timeline/IntentionalMentions.swift 0.00% 3 Missing ⚠️
...ens/ComposerToolbar/ComposerToolbarViewModel.swift 90.00% 0 Missing and 1 partial ⚠️
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2327      +/-   ##
===========================================
- Coverage    72.64%   72.53%   -0.11%     
===========================================
  Files          511      512       +1     
  Lines        35319    35327       +8     
  Branches     16990    16998       +8     
===========================================
- Hits         25657    25626      -31     
- Misses        9034     9077      +43     
+ Partials       628      624       -4     
Flag Coverage Δ
unittests 57.86% <54.83%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 enabled auto-merge (squash) January 12, 2024 11:37
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Velin92 Velin92 merged commit 1001b5d into develop Jan 12, 2024
5 checks passed
@Velin92 Velin92 deleted the mauroromito/revert_using_sdk_markdown branch January 12, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich text editor fails parsing lists Crash when pasting XML into the RTE
2 participants