Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent crashes when computing aspect ratios on zero media width or h… #2437

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Prevent crashes when computing aspect ratios on zero media width or h… #2437

merged 1 commit into from
Feb 8, 2024

Conversation

stefanceriu
Copy link
Member

…eight

@stefanceriu stefanceriu requested a review from a team as a code owner February 8, 2024 15:18
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 8, 2024 15:18
@stefanceriu stefanceriu force-pushed the stefan/fixZeroWidthHeightAspectRatio branch from b4b9224 to e5ccccc Compare February 8, 2024 15:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e5ccccc

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu enabled auto-merge (rebase) February 8, 2024 15:36
@stefanceriu stefanceriu merged commit e1d1e99 into develop Feb 8, 2024
5 checks passed
@stefanceriu stefanceriu deleted the stefan/fixZeroWidthHeightAspectRatio branch February 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Velin92 Velin92 Velin92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @Velin92