Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stream_positions table #17047

Closed
wants to merge 12 commits into from
Closed

Remove stream_positions table #17047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
de5fb2c
Toss out almost all references to 'stream_positions'
realtyem Mar 29, 2024
62e053e
_current_positions will have no values at this point in startup, as i…
realtyem Mar 29, 2024
ab5484c
Replace the SQL loading positions from `stream_positions` at start wi…
realtyem Mar 29, 2024
2e3c09b
Update unit tests to remove references to `stream_positions`. Some te…
realtyem Mar 29, 2024
aff92f0
Remove old generation of min_stream_id as it is already handled, and …
realtyem Mar 31, 2024
cec51f6
This can all be removed as it was handled above
realtyem Mar 31, 2024
644fe9b
Drive-by small comment typo/grammer/spelling fixups(because I don't l…
realtyem Mar 31, 2024
0c8ded9
Update unit test MultiTableMultiWriterIdGeneratorTestCase.test_load_e…
realtyem Mar 31, 2024
12e8977
Update unit test MultiWriterIdGenerator.test_writer_config_change()
realtyem Mar 31, 2024
547569d
save a note
realtyem Mar 31, 2024
e98b03b
changelog
realtyem Apr 4, 2024
8bc9595
Remove a TODO comment from test
realtyem Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.d/17047.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Remove need for `stream_positions` table.

1 change: 0 additions & 1 deletion synapse/storage/databases/main/account_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="account_data",
instance_name=self._instance_name,
tables=[
("room_account_data", "instance_name", "stream_id"),
Expand Down
1 change: 0 additions & 1 deletion synapse/storage/databases/main/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ def __init__(
db_conn,
database,
notifier=hs.get_replication_notifier(),
stream_name="caches",
instance_name=hs.get_instance_name(),
tables=[
(
Expand Down
1 change: 0 additions & 1 deletion synapse/storage/databases/main/deviceinbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="to_device",
instance_name=self._instance_name,
tables=[
("device_inbox", "instance_name", "stream_id"),
Expand Down
3 changes: 0 additions & 3 deletions synapse/storage/databases/main/events_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="events",
instance_name=hs.get_instance_name(),
tables=[("events", "instance_name", "stream_ordering")],
sequence_name="events_stream_seq",
Expand All @@ -212,7 +211,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="backfill",
instance_name=hs.get_instance_name(),
tables=[("events", "instance_name", "stream_ordering")],
sequence_name="events_backfill_stream_seq",
Expand Down Expand Up @@ -314,7 +312,6 @@ def get_chain_id_txn(txn: Cursor) -> int:
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="un_partial_stated_event_stream",
instance_name=hs.get_instance_name(),
tables=[
("un_partial_stated_event_stream", "instance_name", "stream_id")
Expand Down
1 change: 0 additions & 1 deletion synapse/storage/databases/main/presence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="presence_stream",
instance_name=self._instance_name,
tables=[("presence_stream", "instance_name", "stream_id")],
sequence_name="presence_stream_sequence",
Expand Down
1 change: 0 additions & 1 deletion synapse/storage/databases/main/receipts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="receipts",
instance_name=self._instance_name,
tables=[("receipts_linearized", "instance_name", "stream_id")],
sequence_name="receipts_sequence",
Expand Down
1 change: 0 additions & 1 deletion synapse/storage/databases/main/room.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,6 @@ def __init__(
db_conn=db_conn,
db=database,
notifier=hs.get_replication_notifier(),
stream_name="un_partial_stated_room_stream",
instance_name=self._instance_name,
tables=[
("un_partial_stated_room_stream", "instance_name", "stream_id")
Expand Down
Loading
Loading