Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone dropdown #106

Merged
merged 26 commits into from
Aug 6, 2024
Merged

Timezone dropdown #106

merged 26 commits into from
Aug 6, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 16, 2022

Replaces a bunch of deprecated stuff with a Gtk.Dropdown that has search

Fixes #119

@danirabbit danirabbit requested a review from a team February 7, 2024 20:25
@danirabbit danirabbit marked this pull request as ready for review February 7, 2024 20:30
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the chosen timezone is not selected after restarting System Settings. Instead, the first timezone in the list is selected:

Screenshot from 2024-02-12 19-21-18

I'm using the system in Japanese so maybe a locale issue. (running the System Setting with setting LANG=C works fine)

src/Widgets/TimeZoneGrid.vala Outdated Show resolved Hide resolved
src/Widgets/TimeZoneGrid.vala Outdated Show resolved Hide resolved
src/Widgets/TimeZoneGrid.vala Show resolved Hide resolved
src/Widgets/TimeZoneGrid.vala Outdated Show resolved Hide resolved
src/Widgets/TimeZoneGrid.vala Show resolved Hide resolved
src/Widgets/TimeZoneGrid.vala Outdated Show resolved Hide resolved
@vjr
Copy link
Member

vjr commented Jul 6, 2024

This PR works for me, fixes #119 at least, plus I've opened a PR #127 to be merged into this one.

vjr and others added 2 commits July 31, 2024 13:03
* Fix missing minutes portion of timezone UTC offset

* Change dot to colon in UTC offset

* Use abs () for minutes for negative offset
@ryonakano
Copy link
Contributor

For me, the chosen timezone is not selected after restarting System Settings. Instead, the first timezone in the list is selected:

Screenshot from 2024-02-12 19-21-18

I'm using the system in Japanese so maybe a locale issue. (running the System Setting with setting LANG=C works fine)

I fixed this issue in #128

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it looks like we need to update the screenshot again :)

@danirabbit
Copy link
Member Author

@ryonakano done!

@danirabbit danirabbit requested a review from ryonakano August 6, 2024 17:18
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected! Also don't forget to update the Build-Depends list in the deb-packaging branch too 😉

@danirabbit
Copy link
Member Author

@ryonakano here you go #130

@danirabbit danirabbit merged commit acdd3c1 into main Aug 6, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the timezone-dropdown branch August 6, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect TimeZoneGrid city view scroll position
4 participants