Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infobar width #232

Closed
wants to merge 2 commits into from
Closed

fix: infobar width #232

wants to merge 2 commits into from

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Oct 7, 2024

Before:
image

After
image

danirabbit
danirabbit requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the infobar inside of the clamp is a good idea, but I think it just needs to be inside of content_grid instead of moving around all of these other widgets

src/Views/UserSettingsView.vala Outdated Show resolved Hide resolved
@alainm23
Copy link
Contributor Author

alainm23 commented Oct 9, 2024

Fixed
image

@danirabbit danirabbit mentioned this pull request Oct 9, 2024
Merged
@danirabbit
Copy link
Member

@alainm23 I actually wanted to change this layout a lot anyways: #233

@alainm23
Copy link
Contributor Author

I love it, I was thinking the same thing, I just wanted to propose a design change.

@alainm23 alainm23 closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alainm23 @danirabbit