Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserSettingsView: layout vertically, remove lock images #233

Merged
merged 2 commits into from
Oct 10, 2024
Merged

UserSettingsView: layout vertically, remove lock images #233

merged 2 commits into from
Oct 10, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 9, 2024 •
edited
Loading

Closes #232

  • Layout contents vertically. Fits in with modern layouts in other panes
  • Use secondary text for explanations instead of tooltip text on locks which can't really be read easily on touch
  • Set mnemonic widgets

Screenshot from 2024-10-09 16 53 36
Screenshot from 2024-10-09 16 53 48

@danirabbit danirabbit requested a review from a team October 9, 2024 23:59
@danirabbit danirabbit mentioned this pull request Oct 9, 2024
Closed
@danirabbit danirabbit merged commit 1ce9fb2 into main Oct 10, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/usersettingsview-verticallayout branch October 10, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alainm23 alainm23 alainm23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @alainm23