Updates Code to handle multi-valued alts and remove default value for Genomic Source Class #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Records with multiple alts must be split into multiple variant records.
Updates Converter Class to have genomic source class as a required parameter without a default value. type check for genomicSourceClass
srgothi92
approved these changes
Mar 7, 2022
rhdolin
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a combination of two commits:
Somatic) for thegenomicSourceClassparameter.Fixes #96
How Has This Been Tested?
The code has been tested by running all the unit tests using the command
python -m unittestand the PEP 8 formatting was validated usingpycodestyle.