Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove eslint, prettier, tslint and replace with biome #2439

Merged
merged 9 commits into from
Jan 18, 2025

Conversation

0xSero
Copy link
Contributor

@0xSero 0xSero commented Jan 17, 2025

Relates to

Migrating from ESLint/Prettier to Biome

Risks

Low - Code style and linting changes only. No functional changes.
Low - The lint fixes will be progressive i have turned off a lot of default errors existing in biome but not eslint, we can turn them on one by one later, and deal with the changes

Background

What does this PR do?

  • Removes ESLint and Prettier configurations and dependencies
  • Adds Biome for unified linting and formatting
  • Updates CI workflow to use Biome
  • Updates scripts to use Biome commands

What kind of change is this?

Updates (replacing existing linting and formatting tools with Biome)

Documentation changes needed?

My changes require a change to the project documentation:

  • Update development setup instructions to mention Biome instead of ESLint/Prettier
  • Update contributing guidelines with new formatting commands

Testing

Where should a reviewer start?

  1. Review the new biome.json configuration
  2. Check the updated CI workflow
  3. Verify package.json changes (removed old dependencies, added Biome)

Detailed testing steps

  1. Clone the branch
  2. Run pnpm install
  3. Run pnpm check to verify Biome works
  4. Make some code changes and verify formatting works with pnpm format
  5. Run the test suite to ensure nothing was broken

Files Changed

  • Added biome.json
  • Updated .github/workflows/ci.yaml
  • Updated root package.json
  • Removed ESLint/Prettier configs:
    • Deleted .eslintrc.* files
    • Deleted .prettierrc.* files
    • Deleted eslint.config.* files

Deploy Notes

No special deployment steps needed. Changes are development-tooling only.

Discord username

0xSero

@0xSero 0xSero marked this pull request as ready for review January 17, 2025 12:00
@0xSero 0xSero marked this pull request as draft January 17, 2025 12:02
@0xSero 0xSero marked this pull request as ready for review January 17, 2025 12:06
@JoeyKhd
Copy link
Member

JoeyKhd commented Jan 17, 2025

I have an outstanding branch that also leverages Lefthook so that at least formatting runs whenever one tries to create a commit.

https://github.com/JoeyKhd/eliza/tree/biome-lefthook

Have not managed to finish it up entirely. But one of the things that I see here in your PR that is has not updated the defaultFormatters across the board.

@0xSero
Copy link
Contributor Author

0xSero commented Jan 17, 2025

I have an outstanding branch that also leverages Lefthook so that at least formatting runs whenever one tries to create a commit.

https://github.com/JoeyKhd/eliza/tree/biome-lefthook

Have not managed to finish it up entirely. But one of the things that I see here in your PR that is has not updated the defaultFormatters across the board.

I am hoping to do this in a phased approach, it's a very big pr as is.

twilwa
twilwa previously approved these changes Jan 18, 2025
Copy link
Collaborator

@twilwa twilwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will go ahead and approve but didn't go through all changes; running pnpm check comes up with a few warnings but does run successfully. LGTM tho

auto-merge was automatically disabled January 18, 2025 07:32

Head branch was pushed to by a user without write access

@wtfsayo wtfsayo changed the title Improvement: Remove eslint, prettier, tslint and replace with biome chore: Remove eslint, prettier, tslint and replace with biome Jan 18, 2025
@wtfsayo wtfsayo changed the title chore: Remove eslint, prettier, tslint and replace with biome chore: remove eslint, prettier, tslint and replace with biome Jan 18, 2025
@wtfsayo wtfsayo merged commit d30b341 into elizaOS:develop Jan 18, 2025
9 of 11 checks passed
mgunnin added a commit to mgunnin/eliza-agent that referenced this pull request Jan 18, 2025
…o develop

* 'develop' of https://github.com/mgunnin/virtualDegen: (41 commits)
  Update README.md (elizaOS#2495)
  Update README_CN.md (elizaOS#2489)
  Update README_JA.md (elizaOS#2490)
  feat: introduce Dependency Injection to enhance developer experience (elizaOS#2115)
  chore: corrected the link to the banner (elizaOS#2491)
  chore: update createToken.ts (elizaOS#2493)
  feat: Solana plugin improvement for flawless transfers (elizaOS#2340)
  Update README_DE.md (elizaOS#2483)
  feat: Sui supports the secp256k1/secp256r1 algorithms (elizaOS#2476)
  chore: remove eslint, prettier, tslint and replace with biome (elizaOS#2439)
  chore: let -> const
  fix: lint command
  fix: unused import and type errors
  chore: console -> elizaLogger
  fix: error logging and remove unused import
  fix: remove unused error var
  chore: pnpm lock file
  add openai var
  Revert "Revert "refactor: dockerize smoke tests (elizaOS#2420)" (elizaOS#2459)"
  fix swaps evm plugin (elizaOS#2332)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants