-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove eslint, prettier, tslint and replace with biome #2439
Conversation
I have an outstanding branch that also leverages Lefthook so that at least formatting runs whenever one tries to create a commit. https://github.com/JoeyKhd/eliza/tree/biome-lefthook Have not managed to finish it up entirely. But one of the things that I see here in your PR that is has not updated the defaultFormatters across the board. |
I am hoping to do this in a phased approach, it's a very big pr as is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will go ahead and approve but didn't go through all changes; running pnpm check comes up with a few warnings but does run successfully. LGTM tho
Head branch was pushed to by a user without write access
…o develop * 'develop' of https://github.com/mgunnin/virtualDegen: (41 commits) Update README.md (elizaOS#2495) Update README_CN.md (elizaOS#2489) Update README_JA.md (elizaOS#2490) feat: introduce Dependency Injection to enhance developer experience (elizaOS#2115) chore: corrected the link to the banner (elizaOS#2491) chore: update createToken.ts (elizaOS#2493) feat: Solana plugin improvement for flawless transfers (elizaOS#2340) Update README_DE.md (elizaOS#2483) feat: Sui supports the secp256k1/secp256r1 algorithms (elizaOS#2476) chore: remove eslint, prettier, tslint and replace with biome (elizaOS#2439) chore: let -> const fix: lint command fix: unused import and type errors chore: console -> elizaLogger fix: error logging and remove unused import fix: remove unused error var chore: pnpm lock file add openai var Revert "Revert "refactor: dockerize smoke tests (elizaOS#2420)" (elizaOS#2459)" fix swaps evm plugin (elizaOS#2332) ...
Relates to
Migrating from ESLint/Prettier to Biome
Risks
Low - Code style and linting changes only. No functional changes.
Low - The lint fixes will be progressive i have turned off a lot of default errors existing in biome but not eslint, we can turn them on one by one later, and deal with the changes
Background
What does this PR do?
What kind of change is this?
Updates (replacing existing linting and formatting tools with Biome)
Documentation changes needed?
My changes require a change to the project documentation:
Testing
Where should a reviewer start?
biome.json
configurationDetailed testing steps
pnpm install
pnpm check
to verify Biome workspnpm format
Files Changed
biome.json
.github/workflows/ci.yaml
package.json
.eslintrc.*
files.prettierrc.*
fileseslint.config.*
filesDeploy Notes
No special deployment steps needed. Changes are development-tooling only.
Discord username
0xSero