Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: "refactor: dockerize smoke tests" #2459

Merged
merged 1 commit into from
Jan 17, 2025
Merged

revert: "refactor: dockerize smoke tests" #2459

merged 1 commit into from
Jan 17, 2025

Conversation

twilwa
Copy link
Collaborator

@twilwa twilwa commented Jan 17, 2025

Reverts #2420

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 17, 2025

📝 Walkthrough

Walkthrough

The pull request modifies the GitHub Actions workflow for smoke tests in the .github/workflows/smoke-tests.yml file. The changes involve removing the container specification, simplifying the pnpm setup process, and updating Node.js and pnpm versions. The workflow now uses pnpm/action-setup@v3 and actions/setup-node@v4 to configure the development environment more directly.

Changes

File Change Summary
.github/workflows/smoke-tests.yml - Removed container specification for node:23-bullseye
- Removed separate actions/cache@v4 caching step
- Added pnpm/action-setup@v3 for pnpm setup
- Updated Node.js version to "23.3.0"
- Set explicit pnpm version to 9.15.0
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24729ee and 3aa75bb.

📒 Files selected for processing (1)
  • .github/workflows/smoke-tests.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: integration-tests
  • GitHub Check: smoke-tests
🔇 Additional comments (1)
.github/workflows/smoke-tests.yml (1)

16-18: LGTM! Clean pnpm setup.

Using the official pnpm action with a pinned version ensures consistent package management.

.github/workflows/smoke-tests.yml Show resolved Hide resolved
@wtfsayo wtfsayo enabled auto-merge (squash) January 17, 2025 20:32
@wtfsayo wtfsayo self-requested a review January 17, 2025 20:32
@wtfsayo wtfsayo changed the title Revert "refactor: dockerize smoke tests" revert: "refactor: dockerize smoke tests" Jan 17, 2025
@wtfsayo wtfsayo merged commit e28353c into develop Jan 17, 2025
6 of 9 checks passed
@wtfsayo wtfsayo deleted the revert-2420-feat/dockerize-smoke-tests branch January 17, 2025 20:33
wtfsayo added a commit that referenced this pull request Jan 17, 2025
@wtfsayo
Revert "Revert "refactor: dockerize smoke tests (#2420)" (#2459)"
88af7a7 
This reverts commit e28353c.
@wtfsayo wtfsayo mentioned this pull request Jan 17, 2025
Merged
mgunnin added a commit to mgunnin/kairos that referenced this pull request Jan 18, 2025
@mgunnin
Merge branch 'develop' of https://github.com/mgunnin/virtualDegen int…
8ae6ae4 
…o develop

* 'develop' of https://github.com/mgunnin/virtualDegen: (41 commits)
  Update README.md (elizaOS#2495)
  Update README_CN.md (elizaOS#2489)
  Update README_JA.md (elizaOS#2490)
  feat: introduce Dependency Injection to enhance developer experience (elizaOS#2115)
  chore: corrected the link to the banner (elizaOS#2491)
  chore: update createToken.ts (elizaOS#2493)
  feat: Solana plugin improvement for flawless transfers (elizaOS#2340)
  Update README_DE.md (elizaOS#2483)
  feat: Sui supports the secp256k1/secp256r1 algorithms (elizaOS#2476)
  chore: remove eslint, prettier, tslint and replace with biome (elizaOS#2439)
  chore: let -> const
  fix: lint command
  fix: unused import and type errors
  chore: console -> elizaLogger
  fix: error logging and remove unused import
  fix: remove unused error var
  chore: pnpm lock file
  add openai var
  Revert "Revert "refactor: dockerize smoke tests (elizaOS#2420)" (elizaOS#2459)"
  fix swaps evm plugin (elizaOS#2332)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@wtfsayo wtfsayo wtfsayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twilwa @wtfsayo