Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Bowtie2 to a working version #51

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Pin Bowtie2 to a working version #51

merged 1 commit into from
Jun 30, 2020

Conversation

marcelm
Copy link
Collaborator

@marcelm marcelm commented Jun 30, 2020

Bowtie2 2.4.1, which we get otherwise at the moment, is packaged incorrectly in Bioconda, see bioconda/bioconda-recipes#22836.

With this, we no longer get this error message from je markdupes:

htsjdk.samtools.SAMFormatException: Error parsing SAM header. Problem parsing @PG key:value pair.

Bowtie2 2.4.1, which we get otherwise at the moment, is packaged incorrectly
in Bioconda, see <bioconda/bioconda-recipes#22836>.
@cnluzon
Copy link
Collaborator

cnluzon commented Jun 30, 2020

Oh I see, that was some great debugging, the SAM header error was not exactly giving that away.

@marcelm marcelm merged commit bd0fba1 into master Jun 30, 2020
@marcelm marcelm deleted the samheader branch June 30, 2020 11:56
marcelm added a commit that referenced this pull request Oct 28, 2021
The reason for restricting the version to 2.3.5.1 was that the tool would
create incorrect VN tags in the SAM header, see #51. This bug has since
been fixed according to
bioconda/bioconda-recipes#22836 .

The upstream issue at BenLangmead/bowtie2#301 was
re-opened, though.

Closes #121
@marcelm marcelm mentioned this pull request Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants