This repository has been archived by the owner on Dec 10, 2024. It is now read-only.
Update to pull ember-mocha from NPM. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
pull-ember-mocha-from-npm
branch
from
5181be4 to
4c4b402
Compare
|
Confirmed locally in a 2.3.0-beta.1 app and a 1.13.1 app. Both sides seem to be working properly. |
rwjblue
added a commit
that referenced
this pull request
Feb 1, 2016
Update to pull ember-mocha from NPM.
| @@ -13,9 +13,11 @@ module.exports = { | |||
| var addonContext = this; | |||
|
|
|||
| return this.addBowerPackagesToProject([ | |||
| { name: 'mocha', source: 'mocha', target: '~2.2.4' }, | |||
| { name: 'chai', source: 'chai', target: '~2.3.0' }, | |||
| { name: 'ember-mocha-adapter', source: 'ember-mocha-adapter', target: '~0.3.1' }, | |||
| { name: 'ember-mocha', source: 'ember-mocha', target: '~0.8.8' }, | |||
There was a problem hiding this comment.
shouldn't this be removed too if it's already in the package.json file now?
There was a problem hiding this comment.
Yes. I must have missed it :(
Would you mind submitting a PR?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows suit with ember-cli/ember-cli-qunit#92.