Use ember-qunit as an NPM dependency. #92
Conversation
|
👍 This would give us more reason to solve the addon test support issue :P |
|
Ya, agree. I'm looking into that in ember-cli (possibly for 2.x). |
This removes ember-qunit as a bower dependency (in favor of using NPM directly). Currently, this uses ember-cli's new `treeForAddonTestSupport` hook to provide ember-qunit, ember-test-helpers, and klassy for concatenation into `assets/test-support.js`. This will either require a backwards compat shim (for older versions of Ember CLI) or it will depend upon the newer Ember CLI version after that new hook is added.
rwjblue
force-pushed
the
add-ember-qunit-via-npm
branch
from
ddc5db4 to
67d2598
Compare
|
Updated to utilize Ultimately, this will either require a backwards compat shim (for older versions of Ember CLI) or it will depend upon the newer Ember CLI version after that new hook is added (and require a major version bump). |
|
ember-cli/ember-cli#5205 is merged upstream but will not be available to consumers until [email protected] ships. I have updated this PR to enable backwards compat with older Ember CLI versions so that this is not a breaking change. We can remove the backwards compat shim layer, when we bump major versions. |
rwjblue
changed the title
Use ember-qunit as an NPM dependency.
This removes ember-qunit as a bower dependency (in favor of using NPM
directly).
Currently, this adds ember-qunit, ember-test-helpers, and klassy
(required by ember-test-helpers) to
vendor.js. That is slightlyunfortunate, as ideally these would be added to
test-support.jsinstead, however there is no mechanism other than
app.importinember-cli today (1.13.x timeframe) to handle this.
IMO, we should add a
addon-test-supporttree, that appends totest-support.jsby default. This would allow addons to provide testhelpers much simpler than we can today.