Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ember.Freezable support #31

Merged
merged 3 commits into from
Dec 19, 2017
Merged

Add Ember.Freezable support #31

merged 3 commits into from
Dec 19, 2017

Conversation

thoov
Copy link
Member

@thoov thoov commented Dec 19, 2017

Related ember.js PR

Closes: #7

@thoov
Copy link
Member Author

thoov commented Dec 19, 2017

@rwjblue @bekzod could you guys take a look at this when you get a chance

}, '`frozenCopy` is deprecated, use `Object.freeze` instead.');
});

test('Ember.Freezable should be deprecated', assert => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you normalize to function(assert) {?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@locks. Fixed!

@rwjblue rwjblue merged commit ace1893 into emberjs:master Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants