Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] remove Freezable #15891

Merged
merged 1 commit into from
Dec 1, 2017
Merged

[CLEANUP] remove Freezable #15891

merged 1 commit into from
Dec 1, 2017

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Nov 30, 2017

No description provided.

@bekzod bekzod changed the title remove Freezable [CLEANUP] remove Freezable Nov 30, 2017
@bekzod bekzod mentioned this pull request Nov 30, 2017
34 tasks
@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2017

Can you create a corresponding PR (or issue that links back here) at https://github.com/emberjs/ember-2-legacy? All of the API functionality we remove from this repo for 3.0 must be "re-enableable" by including that addon. If a particular change can't be provided by the addon directly, we will need to wrap the functionality in if (ENV._FOO) { style conditionals so that the addon can re-enable the API.

@rwjblue rwjblue merged commit e3842d7 into emberjs:master Dec 1, 2017
@rwjblue
Copy link
Member

rwjblue commented Dec 1, 2017

Thank you!

@bekzod bekzod deleted the remove-freezable branch December 1, 2017 13:44
thoov added a commit to thoov/ember.js that referenced this pull request Dec 14, 2017
Removing the unused imports that can be removed from the Freezable
PR emberjs#15891.
lorcan pushed a commit to lorcan/ember.js that referenced this pull request Feb 6, 2018
Removing the unused imports that can be removed from the Freezable
PR emberjs#15891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants