Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nested partials within an {{each}} #15797

Merged
merged 1 commit into from
Nov 1, 2017
Merged

fix nested partials within an {{each}} #15797

merged 1 commit into from
Nov 1, 2017

Conversation

GavinJoyce
Copy link
Member

this is a similar issue to ones outlined in #15621:

screen shot 2017-10-31 at 08 24 31

@GavinJoyce GavinJoyce mentioned this pull request Oct 31, 2017
Closed
@mani-mishra
Copy link
Contributor

Seems related to #15791

@GavinJoyce
Copy link
Member Author

Like the previous partial issues, this was introduced in ember 2.15, it works in 2.14

@rwjblue
Copy link
Member

rwjblue commented Oct 31, 2017

/cc @kratiahuja (failing tests in Ember for #15791).

@GavinJoyce
Copy link
Member Author

GavinJoyce commented Nov 1, 2017 •
edited
Loading

I believe that this fixes it: glimmerjs/glimmer-vm#730 (although we'll have to backport a similar fix to v0.25.5)

@GavinJoyce
Copy link
Member Author

I added a second failing test for deeply nested partials and with blocks:

screen shot 2017-11-01 at 12 58 35

@GavinJoyce GavinJoyce mentioned this pull request Nov 1, 2017
Merged
@kratiahuja
Copy link
Contributor

Thank you @GavinJoyce !

@rwjblue
Copy link
Member

rwjblue commented Nov 1, 2017

I just pushed a commit bumping to glimmer-vm packages 0.25.5 which includes glimmerjs/glimmer-vm#732.

@GavinJoyce GavinJoyce changed the title failing test for nested partials within an {{each}} fix nested partials within an {{each}} Nov 1, 2017
@GavinJoyce
Copy link
Member Author

🍏

@rwjblue rwjblue merged commit 21889ab into emberjs:master Nov 1, 2017
@GavinJoyce GavinJoyce deleted the gj/nested-partials branch November 1, 2017 20:48
@chancancode
Copy link
Member

Thank you @kratiahuja and @GavinJoyce!

@rwjblue rwjblue mentioned this pull request Nov 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GavinJoyce @mani-mishra @rwjblue @kratiahuja @chancancode