[0.25] fix nested partials

[GavinJoyce]

fixes #728
addresses emberjs/ember.js#15791 (will be fixed once we release a new ember version with this change)

[GavinJoyce]

I'm unclear on the differences between locals and evalScope. Some questions:

1. should locals contain the outerScope.getPartialMap() like I'm doing above or perhaps it belongs in evalScope?
2. when iterating over the partialSymbols, should we just be checking evalScope or is it ok to fallback to locals too?

[krisselden]

locals are supposed to win, they are names the partial introduced.

[GavinJoyce]

thanks

[GavinJoyce]

CI seems flaky:

not ok 1 PhantomJS - error
    ---
        message: >
            Error: Browser exited unexpectedly
            Non-zero exit code: 127
            Stderr: 
             phantomjs: error while loading shared libraries: libicui18n.so.48: cannot open shared object file: No such file or directory
            
            
        Log: |
            { type: 'error', text: 'Error: Browser exited unexpectedly' }
            { type: 'error', text: 'Non-zero exit code: 127' }
            { type: 'error',
              text: 'phantomjs: error while loading shared libraries: libicui18n.so.48: cannot open shared object file: No such file or directory\n' }

Tests pass locally:

[GavinJoyce]

This is ready for review

[GavinJoyce]

Hm, I think I'll change this to

Hi {{person1}}. {{#with 'Sophie' as |person1|}}Hi {{person1}}...

so that we render something from the outer conext

[rwjblue]

👍 sounds good

[GavinJoyce]

updated

[rwjblue]

We can't rely on Object.assign in this version, we have a shared assign utility method that we can use though.

glimmer-vm/packages/@glimmer/util/lib/object-utils.ts

Line 10 in 1759c16

export function assign(obj: any) {

[GavinJoyce]

updated, thanks

[GavinJoyce]

This test seems superfluous now that we have the nested partials within nested {{#with}} blocks test below, I'll remove it

[rwjblue]

Totally up to you, it certainly doesn't hurt to have two tests...

[GavinJoyce]

I'll port these changes to master now in #730