Te Fiti #154
Merged
Te Fiti #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-extended # Conflicts: # package.json # test/__snapshots__/css.test.js.snap # test/__snapshots__/react.test.js.snap
…-extended # Conflicts: # package.json # test/__snapshots__/css.test.js.snap # test/__snapshots__/react.test.js.snap
…-extended # Conflicts: # src/babel.js
…to glamor-extended # Conflicts: # src/babel.js # src/inline.js # src/parser.js
emmatown
reviewed
Jul 23, 2017
src/index.js
Outdated
| mq, | ||
| supp, | ||
| src: _src[key] | ||
| }) |
There was a problem hiding this comment.
Should we remove this? I added tests for this and we add the webkit and ms prefixes in the babel plugin (not the moz one since the usage of firefox versions that require the prefix is under 1%) for tagged template literals but not for objects, we could probably do it for objects if we wanted to.
There was a problem hiding this comment.
Yes remove this whole thing
emmatown
reviewed
Jul 24, 2017
| name, | ||
| checkRenderMessage(owner) | ||
| ) | ||
| : void 0 |
There was a problem hiding this comment.
Do we want to keep all these warnings?
… store the AST and expressions of an object in an instance of ASTObject and then use that in parseCSS.
This was referenced Jul 25, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
extractStaticoption - Inline mode but if the block has 0 interpolations it is extracted into a file. If users choose, they can write all static styles and use inline styles for dynamic values. Any static style blocks are replaced with a string class name by the emotion plugin.is replaced with a string like
Why:
Composition is awesome and predictable.
TODO:
/glamorfolder and use some smaller code for that (maybe from cxs or postcss-js)[].forEach|map|reducewith their equivilents from./utilsfor consistancydisplay: flexis converted todisplay: -webkit-box,-moz-box,-ms-flexbox,-webkit-flex,flexIf you want to help please feel free to make a PR against this branch
glamor-extended