-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Te Fiti #154
Merged
Merged
Te Fiti #154
Changes from 45 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
143c4a4
Initial working version of using glamor core instead of cxs
f6b1798
Bump bundle size
8a509b9
Merge branch 'master' into glamor
a03ea53
Merge branch 'master' of https://github.com/tkh44/emotion into glamor
2c00641
Correctly merge styles.
94eaaaa
Merge remote-tracking branch 'origin/glamor' into glamor
4c37c76
Merge branch 'master' into glamor
833f82d
Update snapshots and add test for composition with objects
6a494f8
initial work
83a3bd9
getting it how i want it
ddb7916
Merge branch 'master' of https://github.com/tkh44/emotion into glamor…
18c46e6
Progress
dbee53c
Merge branch 'master' of https://github.com/tkh44/emotion into glamor…
c819e19
Merge branch 'master' of https://github.com/tkh44/emotion into glamor…
9391ed2
Merge branch 'master' of https://github.com/tkh44/emotion into glamor…
d332fe7
Fix flow types
be90c45
pass the obj styles back to babel.js
2bbafa8
Stuff
emmatown 4bd77d9
Merge branch 'master' into glamor-extended
emmatown 5e2296d
Deleting more code. Its broken state but its progress
fc4632c
Merge branch 'glamor-extended' of https://github.com/tkh44/emotion in…
6439272
broke broke broke
8e535fd
Formatting
0ad13c8
Use postcss-js objectify and change dynamic value parsing
emmatown 68ad756
I broke css but styled is great now
emmatown e32b77c
ITS WORKING
e52a61a
more progress
2cd0f5c
working setup
b92058b
Major progress getting composing working
7436946
Update snapshots
708ccb9
Work on composing
f3ade2c
composes is working with props & component
6735c1f
Merge branches 'glamor-extended' and 'master' of https://github.com/t…
f85d322
copy over reduce
c247420
font face working. Not sure how to do do injectGlobal though.
c18043a
- injectGlobal ✅
d73affe
🎉 All tests passing
3e509a6
Merge branch 'master' into glamor-extended
emmatown 6882afa
Little fixes, removing unused vars and other small stuff
emmatown 03de7b7
Remove unused import and fn
emmatown e961314
Make the code more clear by moving parseCSS into babel.js
75ad839
- Remove code that added `.` to component selectors
e860520
Fix example site demos
7886bbe
Add test for dynamic properties of styled
cd4a25a
add failing snapshots
d44c6ba
Remove shorthandPropertyExpansions
emmatown 1bb13e3
wtf is this bug
f3db5eb
fixed - bad parsing for values like `50%`
08ce19b
Formatting, remove unused stuff, remove useless regex escapes and fix…
emmatown f391862
Add tests for ::placeholder
emmatown 975a383
Add rollup-plugin-replace
emmatown b063ff6
Remove stuff for ::placeholder
emmatown 3f6ef03
Use jest-glamor-react instead of custom jest-utils
emmatown 49b01f1
Working on example
f0094f8
Add grid properties to unitless list
ad08e03
Add `fromAST` to ASTObject so that we can extract static objs. We can…
762207b
Add pure comments before calls to css, keyframes and styled
emmatown 1846d4b
Fix ASTObject.fromAST
emmatown 2e259ae
It works for css calls
emmatown 1982133
Prettier and expand try
emmatown 50b59c2
Fix path removing and add pure comment to styled calls
emmatown 1568141
Remove prefixAst
emmatown a98de81
Prefix object styles in the macro
emmatown 1e88e34
Add tests for calling css without any args
emmatown af32351
Tests
emmatown e8b612c
More tests
emmatown 1baa927
Prettier and add more tests
emmatown 1b7036a
Add tests for dynamic keys
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,6 @@ | |
"react" | ||
], | ||
"plugins": [ | ||
'emotion/babel' | ||
['emotion/babel'] | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,6 @@ const Avatar = styled('img')` | |
` | ||
|
||
render( | ||
<Avatar src={avatarUrl} />, | ||
<Avatar src={logoUrl} />, | ||
mountNode | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
const Avatar = styled('div')` | ||
img { | ||
& img { | ||
width: 96px; | ||
height: 96px; | ||
border-radius: 50%; | ||
} | ||
` | ||
|
||
render( | ||
<Avatar><img src={avatarUrl} /></Avatar>, | ||
<Avatar><img src={logoUrl} /></Avatar>, | ||
mountNode | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ import styles from './index.css' | |
|
||
const MarkdownContainer = styled('div')` | ||
composes: ${styles.markdownContainer}; | ||
|
||
h1, h2, h3, h4, h5 { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How come these don't lead with a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cause bug |
||
margin: 16px 0 8px 0; | ||
letter-spacing: 1px; | ||
|
@@ -19,7 +20,7 @@ const Link = styled('a')` | |
text-decoration: none; | ||
color: ${p => p.theme.purple}; | ||
|
||
p & { | ||
& p & { | ||
margin: 0; | ||
} | ||
|
||
|
@@ -34,7 +35,7 @@ const Paragraph = styled('p')` | |
font-size: 0.85rem; | ||
color: ${colors.gray[8]}; | ||
|
||
a { | ||
& a { | ||
font-size: 0.85rem; | ||
} | ||
|
||
|
@@ -47,7 +48,7 @@ const Code = styled('code')` | |
background-color: ${colors.gray[1]}; | ||
padding: 1px; | ||
|
||
p & { | ||
& p & { | ||
font-size: 0.99rem; | ||
} | ||
` | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, is the
&
required now or is it just stylistic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required now because it's how glamor knows to expand the class name