Throw a nice error when using the styled shorthand without babel-plugin-emotion and remove duplication in component selector code #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emotion and remove duplication in component selector stuff
Codecov Report
|
tkh44
approved these changes
Jan 4, 2018
| @@ -165,6 +164,16 @@ function createEmotionStyled(emotion: Emotion, view: ReactType) { | |||
| return Styled | |||
| } | |||
| } | |||
| if (process.env.NODE_ENV !== 'production' && typeof Proxy !== 'undefined') { | |||
| createStyled = new Proxy(createStyled, { | |||
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Throw a nice error when using the styled shorthand without babel-plugin-emotion and remove duplication in component selector code.
Why:
So that people know what to do when they use the shorthand and it doesn't work.
How:
Use a
Proxyif it's available and we're in dev. While this won't work in browsers without Proxies I think it's okay since it's just in dev and most people will be using modern browsers for dev.Checklist: