-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to babel-plugin-macros #525
Conversation
7cbf80d
to
a8c2669
Compare
The tests completely fail on my end because eslint (prettier) expects trailing commas, while they seem to be explicitly forbidden over the code base |
1. ran `yarn eslint . --fix` 2. ran `yarn jest -u` (trailing commas changed snapshots) see emotion-js#525 (comment)
Thanks @Haroenv I'll look at that right now. |
tests are failing on CI because of unrelated linting, AFAICT #526 should fix that |
1. ran `yarn eslint . --fix` 2. ran `yarn jest -u` (trailing commas changed snapshots) see emotion-js#525 (comment)
I didn't do __extensive__ testing, but the tests pass and @kentcdodds said there were no breaking changes… fixes emotion-js#515
a8c2669
to
d579245
Compare
voilà, now without the accidental trailing commas @tkh44 🤷♂️ |
Thanks again |
With pleasure, glad @kentcdodds made it such a smooth upgrade path |
Is there anything else you would like to release with this @mitchellhamilton? Should we backport this to 8? or just run with putting it in 9? |
I just saw the commit message said emotion, but that should have been macros |
@tkh44 Let's just put it in 9 since AFAIK macros built with Maybe @kentcdodds can correct me if I'm wrong? We could do a release now with this and #516 to next. |
Yes, it should actually be totally compatible. All macros using |
I didn't do extensive testing, but the tests pass and @kentcdodds said there were no breaking changes…
fixes #515
What: changed
babel-macros
tobabel-plugin-macros
Why: this is the new name and the one that is going to be incorporated in CRA
How: pretty much find and replace
babel-macros
forbabel-plugin-macros
Checklist: