chore(lint): consistent trailing commas #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. ran `yarn eslint . --fix` 2. ran `yarn jest -u` (trailing commas changed snapshots) see emotion-js#525 (comment)
3 tasks
|
Did prettier change the rules for trailing commas? I'm trying to figure out what I missed. |
|
ugh, now eslint is telling me to remove the trailing commas (it's probably a bug in prettier then 🤔) |
|
We have never had trailing commas. I wonder if there was a bad release somewhere in the chain of deps. I just pulled your branch and it was telling me to remove the commas 🤷♂️ |
|
@tkh44, feel free to remove those then, maybe I had the wrong dependencies in cache somehow 🤔 sorry for the noise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #525 (comment)
What: updated trailing commas
Why: because that's what my
eslintscreamed atHow:
yarn eslint . --fixyarn jest -u(trailing commas changed snapshots)Checklist: