Reusable Media Queries with String Styles wasn't working #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was missing min-width in the media query construction
tkh44
approved these changes
Jan 11, 2018
emmatown
reviewed
Jan 11, 2018
docs/media-queries.md
Outdated
| @@ -95,7 +95,7 @@ const mq = Object.keys(breakpoints).reduce( | |||
| typeof breakpoints[label] === 'string' ? '' : 'px' | |||
| accumulator[label] = cls => | |||
| css` | |||
| @media (${breakpoints[label] + suffix}) { | |||
| @media (min-width:${breakpoints[label] + suffix}) { | |||
There was a problem hiding this comment.
Thanks for the PR! I rewrote this while changing the docs and should've tested it better, this change breaks for the string case though, could you change it to something like this?
let prefix = typeof breakpoints[label] === 'string' ? '' : 'min-width:'
// in the media query interpolation
prefix + breakpoints[label] + suffix
Updated with reference to the comments made by @mitchellhamilton. The Prefix is now determined by whether the value is a string or not
Reusable Media Queries with String Styles wasn't working:2
|
I'm new to contributing to other projects so I hope I have done the right things GitHub wise. But it looks like the changes made with reference to your comment @mitchellhamilton is there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue with the Reusable Media Queries with String Styles example on the website, however when I add min-width: as shown in the pull request it began to work.
I am not sure if the changes I have made are a sufficient fix to update the website but I have updated media-queries.md
Thanks,
Adam