Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable Media Queries with String Styles wasn't working #533

Merged
merged 4 commits into from
Jan 12, 2018
Merged

Reusable Media Queries with String Styles wasn't working #533

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
276caa6
Fixes Reusable Media Queries with String Styles
ARChilton Jan 11, 2018
b94b8df
Merge branch 'master' into master
emmatown Jan 11, 2018
0874123
Updated to include string case
ARChilton Jan 12, 2018
afe77ad
Merge pull request #1 from ARChilton/ARChilton-patch-1
ARChilton Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/media-queries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ const mq = Object.keys(breakpoints).reduce(
typeof breakpoints[label] === 'string' ? '' : 'px'
accumulator[label] = cls =>
css`
@media (${breakpoints[label] + suffix}) {
@media (min-width:${breakpoints[label] + suffix}) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I rewrote this while changing the docs and should've tested it better, this change breaks for the string case though, could you change it to something like this?

let prefix = typeof breakpoints[label] === 'string' ? '' : 'min-width:'
// in the media query interpolation
prefix + breakpoints[label] + suffix

${cls};
}
`
Expand Down