This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Implement performance benchmarking for basic demo #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbestavros
force-pushed
the
performance-benchmarking
branch
3 times, most recently
from
a8aa10b to
c27a5e5
Compare
npmccallum
suggested changes
Sep 5, 2019
mbestavros
force-pushed
the
performance-benchmarking
branch
2 times, most recently
from
96c9bf3 to
44a7ee8
Compare
mbestavros
force-pushed
the
performance-benchmarking
branch
from
44a7ee8 to
c71fb4a
Compare
|
@npmccallum Resolved your comments; ready for re-review. |
npmccallum
approved these changes
Sep 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements performance benchmarking on top of the Wasmtime basic demo from #9. This will be helpful for us to quantify the performance overhead associated with running code on Wasmtime vs. natively.
Resolves #8.