This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
Implement a basic Wasmtime demo #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mbestavros Don't forget that our policy is to squash into logical commits before submitting the PR. |
mbestavros
force-pushed
the
wasmtime-basic-demo
branch
from
8ccaae4 to
6e5fa17
Compare
|
@npmccallum Right, apologies. Done. |
npmccallum
suggested changes
Aug 9, 2019
There was a problem hiding this comment.
-
Run this code through
rustfmt. A simplecargo fmtshould do. -
I think the abstractions (
handle_module()and so on...) aren't holding their weight for this demo. I'd really like to see just the bare wasmtime API in a singlemain()function. -
We probably need to turn on optimization before benchmarks. For clang:
-O3. For rustc:-C opt-level=3.
mbestavros
force-pushed
the
wasmtime-basic-demo
branch
4 times, most recently
from
40ac56f to
c4833f3
Compare
|
@npmccallum Addressed your points. Ready for re-review. |
npmccallum
suggested changes
Aug 12, 2019
mbestavros
force-pushed
the
wasmtime-basic-demo
branch
5 times, most recently
from
f065a46 to
d6c9cf5
Compare
npmccallum
suggested changes
Aug 13, 2019
mbestavros
force-pushed
the
wasmtime-basic-demo
branch
from
d6c9cf5 to
26729d4
Compare
npmccallum
approved these changes
Aug 13, 2019
This was referenced Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a simple demo of Wasmtime and how Enarx may use it.
The demo builds a basic WASM binary from either Rust or C source (selectable at compile time via a Cargo feature), loads it into Wasmtime, and runs it.
This work resolves both #3 and #7. Further WASM demo work will likely build on top of this base.