This repository has been archived by the owner on Apr 15, 2022. It is now read-only.
Improve test coverage, remove asm feature, alignment fixes/precautions
#74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enarxbot
added
debt
rvolosatovs
changed the title
Execute::syscall methodasm feature and a few usability improvements
rvolosatovs
removed
the
discussion
rvolosatovs
commented
Jan 27, 2022
rvolosatovs
force-pushed
the
fix/various
branch
from
83eede8 to
d901a88
Compare
rvolosatovs
changed the title
asm feature and a few usability improvementsasm feature, alignment fixes/precautions
Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
This improves usability. Signed-off-by: Roman Volosatovs <[email protected]>
After stabilization, `asm` feature was only necessary to enable test execution with `miri`, therefore `asm` == `not(miri)`. Signed-off-by: Roman Volosatovs <[email protected]>
Mainly to add context to each test iteration run for simpler debugging, although we should use this to improve parallelism of the tests in future. Signed-off-by: Roman Volosatovs <[email protected]>
Not necessary anymore, since there are no more features defined on the crate Signed-off-by: Roman Volosatovs <[email protected]>
Otherwise, miri complains about UB Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
This improves usability of the method Signed-off-by: Roman Volosatovs <[email protected]>
We have no means to determine the actual alignment of optval if we receive the call via opaque `syscall` method on the guest side and there is no way to determine it on the host side. Align it to `align_of::<usize>()` as a precaution, which is probably the best we can do here. Signed-off-by: Roman Volosatovs <[email protected]>
Signed-off-by: Roman Volosatovs <[email protected]>
rvolosatovs
force-pushed
the
fix/various
branch
from
d901a88 to
85f694b
Compare
haraldh
approved these changes
Jan 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44
Refs enarx/enarx#1730