-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quote): add sgx report types #81
Conversation
Signed-off-by: Nicholas Farshidmehr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo doc
warnings (within the added module):
warning: this URL is not a hyperlink
--> src/report.rs:13:6
|
13 | /// (https://download.01.org/intel-sgx/dcap-1.0/docs/SGX_ECDSA_QuoteGenReference_DCAP_API_Linux_1.0.pdf)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://download.01.org/intel-sgx/dcap-1.0/docs/SGX_ECDSA_QuoteGenReference_DCAP_API_Linux_1.0.pdf>`
|
= note: `#[warn(rustdoc::bare_urls)]` on by default
= note: bare URLs are not automatically turned into clickable links
warning: this URL is not a hyperlink
--> src/report.rs:18:6
|
18 | /// (https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-3d-part-4-manual.ht...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-3d-part-4-manual.html>`
|
= note: bare URLs are not automatically turned into clickable links
warning: this URL is not a hyperlink
--> src/report.rs:93:6
|
93 | /// (https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-3d-part-4-manual.ht...
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-3d-part-4-manual.html>`
|
= note: bare URLs are not automatically turned into clickable links
warning: `sgx` (lib doc) generated 7 warnings
I am not convinced about the added value of a separate report
module. What do you think about either:
a. Having the Report
, ReportBody
, ReportError
defined at the top-level? They may still reside in separate files/modules and be reexported, but IMO importing these as sgx::{Report, ReportBody, ReportError}
is easier to use
b. Moving these to enclu
, right next to where the EREPORT
itself is defined
instead ?
I think reexporting these makes some sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the validity of the actual struct definitions and parsing logic (maybe @jarkkojs should take a look?), but otherwise LGTM.
Signed-off-by: Nicholas Farshidmehr <[email protected]>
Signed-off-by: Nicholas Farshidmehr <[email protected]>
This also removes
quote
types which will remain in steward for now.Closes enarx-archive/sallyport#74