Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ses): anticipate iterator helpers #1655

Merged
merged 1 commit into from
Jul 6, 2023
Merged

feat(ses): anticipate iterator helpers #1655

merged 1 commit into from
Jul 6, 2023

Conversation

erights
Copy link
Contributor

@erights erights commented Jun 28, 2023 •
edited
Loading

Fixes #1289

Anticipate both Iterator Helpers and Async Iterator Helpers.

Note that Iterator Helpers are already as stage 3, so we can expect engines to start shipping these at any time.

Reviewers, please check it against the text of the proposals.

@erights erights requested review from kriskowal and mhofman June 28, 2023 21:17
@erights erights self-assigned this Jun 28, 2023
@erights erights changed the title feat(ses): anticipate interator helpers feat(ses): anticipate iterator helpers Jul 3, 2023
@erights erights force-pushed the markm-1289-anticipate-iteration-helpers branch 5 times, most recently from e720250 to d200cf6 Compare July 3, 2023 09:41
@erights
Copy link
Contributor Author

erights commented Jul 3, 2023

Earlier I wrote

TODO Will remain draft until it actually fixes #1289 . I have not yet added the recognition code.

TODO to test this ahead of engine release, we would need to use or adapt a shim such as https://github.com/zloirock/core-js#iterator-helpers and https://github.com/zloirock/core-js#asynciterator-helpers

Both are now done. This is Ready for Review.

@erights erights marked this pull request as ready for review July 3, 2023 09:41
@erights erights force-pushed the markm-1289-anticipate-iteration-helpers branch from d200cf6 to b0b28a2 Compare July 6, 2023 04:21
This was referenced Jul 6, 2023
Closed
Closed
@erights erights merged commit 7f2d29f into master Jul 6, 2023
@erights erights deleted the markm-1289-anticipate-iteration-helpers branch July 6, 2023 07:04
@mhofman mhofman mentioned this pull request Jul 6, 2023
Merged
@erights erights mentioned this pull request Jul 6, 2023
Closed
zloirock
zloirock reviewed Jul 6, 2023
View reviewed changes
packages/ses/test/test-anticipate-iterator-helpers-shimmed.js
// core-js iterator shim.
// We mutate the permits to tolerates the sloppy functions for testing
// by sacrificing security. The caller and arguments properties of
// sloppy functions violate ocap encapsulation rules.
Copy link

@zloirock zloirock Jul 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core-js use strict mode, but, for modules size economy, not in all cases - for example, in cases where this depends on it. I didn't think that .arguments and .caller are interesting to anyone. I can consider adding the strict mode in all affected cases. You could open an issue in the core-js repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zloirock/core-js#1269

Thanks!

@erights erights mentioned this pull request Jul 7, 2023
Closed
@erights erights mentioned this pull request Jan 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zloirock zloirock zloirock left review comments

@naugtur naugtur naugtur left review comments

@mhofman mhofman mhofman left review comments

@kriskowal kriskowal kriskowal approved these changes

Assignees

@erights erights

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Anticipate new hidden intrinsics: Iteration helpers
5 participants
@erights @kriskowal @mhofman @naugtur @zloirock