fix(ses): fixup async iterator helpers #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
reviewed
Jul 6, 2023
| @@ -146,7 +146,7 @@ export const getAnonymousIntrinsics = () => { | |||
| ); | |||
| } | |||
|
|
|||
| if (globalThis.AsyncInterator) { | |||
| if (globalThis.AsyncIterator) { | |||
There was a problem hiding this comment.
Oops! Thanks for catching this.
erights
reviewed
Jul 6, 2023
| @@ -1317,7 +1317,7 @@ export const permitted = { | |||
|
|
|||
| // https://github.com/tc39/proposal-async-iterator-helpers | |||
| '%AsyncIteratorHelperPrototype%': { | |||
| '[[Proto]]': 'Async%IteratorPrototype%', | |||
| '[[Proto]]': '%AsyncIteratorPrototype%', | |||
There was a problem hiding this comment.
Oops! Thanks for catching this too.
erights
reviewed
Jul 6, 2023
| @@ -0,0 +1,3 @@ | |||
| import module from 'node:module'; | |||
|
|
|||
| module.wrapper[0] += '"use strict";'; | |||
There was a problem hiding this comment.
Frankly, much less painful than I feared ;)
Well the tests caught it, but I have to admit, it was hard to diagnose because ava caught the exception and didn't print out the details (I assume because we're not using ses-ava here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1655 introduced support for iterator helpers, but due to a limitation in the core-js shim usage, the async iterator helper test was disabled, and the PR missed a couple errors in the implementation of permits for the async iterator helpers.
This PR fixes these errors, and addresses the testing limitations so that the iterator helpers tests (both sync and async) can behave more like normal tests.
Closes #1669
Closes #1289