Merge pull request #40 from entando/ENG-4088

ENG-4088 Use session storage instead of query params for menu_open data
entando · Sep 13, 2022 · 39828fa · 39828fa
2 parents 365d486 + c0802af
commit 39828fa
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 9 deletions.
diff --git a/microfrontends/app-builder-menu/src/components/Menu.tsx b/microfrontends/app-builder-menu/src/components/Menu.tsx
@@ -12,7 +12,6 @@ import { MfeConfig } from '../types/globals';
 import { GlobalStyle } from '../styles/globalStyles';
 import { DEFAULT_LOCALE } from '../content';
 import { getPBCNav } from '../api/getPBCNav';
-import { useQueryParams } from '../hooks/common';
 
 interface Props {
   config: MfeConfig;
@@ -37,8 +36,7 @@ export function Menu(props: Props) {
 
   const [dynamicMenuItems, setDynamicMenuItems] = useState<MenuItem[]>([]);
 
-  const queryParams = useQueryParams();
-  const { menu_open } = queryParams || {};
+  const menuOpen = sessionStorage.getItem('menu_open') || '';
 
   const { lang } = window.entando?.globals || {};
   const locale = lang || DEFAULT_LOCALE;
@@ -54,6 +52,19 @@ export function Menu(props: Props) {
     if (config) {
       request();
     }
+
+    const removeMenuOpenSession = () => {
+      sessionStorage.removeItem('menu_open');
+    };
+
+    if (menuOpen) {
+      window.addEventListener('beforeunload', removeMenuOpenSession);
+
+      return () => {
+        removeMenuOpenSession();
+        window.removeEventListener('beforeunload', removeMenuOpenSession);
+      };
+    }
   }, []);
 
   return (
@@ -71,7 +82,7 @@ export function Menu(props: Props) {
             <MenuUI
               config={config}
               dynamicMenuItems={dynamicMenuItems}
-              openDefaultSubmenuId={menu_open}
+              openDefaultSubmenuId={menuOpen}
             />
           </>
         )}

diff --git a/microfrontends/app-builder-menu/src/hooks/common.ts b/microfrontends/app-builder-menu/src/hooks/common.ts