Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-4088 Use session storage instead of query params for menu_open data #40

Merged
merged 5 commits into from
Sep 13, 2022
Merged

ENG-4088 Use session storage instead of query params for menu_open data #40

merged 5 commits into from
Sep 13, 2022

Conversation

raxkaynan
Copy link
Contributor

No description provided.

@Dv92 Dv92 changed the base branch from develop to release/1.0 August 31, 2022 12:43
Dv92
Dv92 reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@Dv92 Dv92 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please delete the hook useQueryParams and the common.ts file, it's not used anymore.

@raxkaynan raxkaynan requested a review from Dv92 September 6, 2022 08:27
@raxkaynan raxkaynan requested a review from Dv92 September 6, 2022 11:14
@Dv92 Dv92 merged commit 39828fa into release/1.0 Sep 13, 2022
@Dv92 Dv92 deleted the ENG-4088 branch September 13, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dv92 Dv92 Dv92 approved these changes

@ichalagashvili ichalagashvili ichalagashvili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raxkaynan @Dv92 @ichalagashvili