Cloned QuicTestServer #1989

carloseltuerto · 2021-12-27T21:05:19Z

This PR was authored by colibie at 95%
Description: copy of pr/1870 authored by colibie where missing bits were added
Risk Level: N/A
Testing: test added
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Charles Le Borgne [email protected]

Signed-off-by: Chidera Olibie <[email protected]>

…TestServer Signed-off-by: Chidera Olibie <[email protected]>

Signed-off-by: Chidera Olibie <[email protected]>

…TestServer

Signed-off-by: Chidera Olibie <[email protected]>

…TestServer Signed-off-by: Chidera Olibie <[email protected]>

Signed-off-by: Chidera Olibie <[email protected]>

…TestServer

Signed-off-by: Chidera Olibie <[email protected]>

Signed-off-by: Charles Le Borgne <[email protected]>

lfpino · 2022-01-13T22:49:03Z

If you're seeing port binding issues on Mac this is probably due to the fact that it's running on a sandbox without network by default. Just do what other tests do:

envoy-mobile/test/kotlin/integration/BUILD

Line 121 in 4710ef4

exec_properties = {

and it should work

Signed-off-by: Charles Le Borgne <[email protected]>

test/java/io/envoyproxy/envoymobile/engine/testing/QuicTestServerTest.java

colibie

Awesome. So happy this finally works.

RyanTheOptimist

Nice! This looks great. A few comments, mostly around comments.

RyanTheOptimist · 2022-01-18T22:27:09Z

test/common/integration/quic_test_server.cc

+  // end pre-setup
+
+  upstream_config_.upstream_protocol_ = Http::CodecType::HTTP3;
+  upstream_config_.udp_fake_upstream_ = FakeUpstreamConfig::UdpConfig();


nit: Could these both be done in the constructor since they don't seem to change per start()?

I moved line 49, but kept line 48: the upstream_protocol will become a parameter soon. the goal is to also use this server to H2 also. Some renaming will take place later.

RyanTheOptimist · 2022-01-18T22:28:00Z

test/common/integration/quic_test_server_interface.h

+extern "C" { // functions
+#endif
+
+void start_server();


nit: Should we have brief comments for these methods?

RyanTheOptimist · 2022-01-18T22:28:23Z

test/common/integration/quic_test_server.cc

+  ON_CALL(factory_context_, scope()).WillByDefault(testing::ReturnRef(stats_store_));
+}
+
+void QuicTestServer::startQuicTestServer() {


Should this perhaps ASSERT(!upstream_)?

RyanTheOptimist · 2022-01-18T22:28:38Z

test/common/integration/quic_test_server.cc

+  ENVOY_LOG_MISC(debug, "Upstream now listening on {}", upstream_->localAddress()->asString());
+}
+
+void QuicTestServer::shutdownQuicTestServer() { upstream_.reset(); }


Should this ASSERT(upstream_)?

RyanTheOptimist · 2022-01-18T22:28:51Z

test/common/integration/quic_test_server.h

+public:
+  QuicTestServer();
+
+  void startQuicTestServer();


Brief comments here would be nice.

RyanTheOptimist · 2022-01-18T22:29:28Z

test/java/io/envoyproxy/envoymobile/engine/testing/QuicTestServer.java

+  private static final AtomicBoolean sServerRunning = new AtomicBoolean();
+
+  /*
+   * Starts the server.


Comment what happens if the server is already running?

RyanTheOptimist · 2022-01-18T22:30:30Z

test/java/io/envoyproxy/envoymobile/engine/testing/QuicTestServer.java

+
+  public static final String getServerCertKey() { return KEY_USED; }
+
+  public static long createMockCertVerifier() {


Out of curiosity, what does the return value represent?

IDK - removed :-)

Signed-off-by: Charles Le Borgne <[email protected]>

RyanTheOptimist

Looks great to me! Thanks for doing this.

* origin/main: (21 commits) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Run Kotlin macOS tests without EngFlow (envoyproxy#2018) final_intel: adding response flags (envoyproxy#2009) fix (envoyproxy#2025) stream intel: update kotlin public interface to align with swift (envoyproxy#2013) tls: update bundled root certificates (envoyproxy#2016) tooling: first pass at oncall tooling (envoyproxy#2014) test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test (envoyproxy#2007) envoy: 519774f742 (envoyproxy#2015) Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006) QuicTestServer (envoyproxy#1989) bump boringssl to Envoy's version (envoyproxy#1999) docs: addding release notes (envoyproxy#2001) release: cutting the 0.4.5 release (envoyproxy#2000) Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998) Decompress even when `no-transform` is specified (envoyproxy#1995) ... Signed-off-by: JP Simard <[email protected]>

colibie added 30 commits September 7, 2021 10:24

Fix url 404 not found error

6e5fca3

Signed-off-by: Chidera Olibie <[email protected]>

Working version of quicTestServer

51bab1c

Signed-off-by: Chidera Olibie <[email protected]>

remove traces of argc and argv

15cfb05

Signed-off-by: Chidera Olibie <[email protected]>

[WIP] create quicTestServerTest

91e1af8

Signed-off-by: Chidera Olibie <[email protected]>

[WIP] quicTestServerTest

a49baf9

Signed-off-by: Chidera Olibie <[email protected]>

[WIP] checkpoint

c608e2e

Signed-off-by: Chidera Olibie <[email protected]>

Merge branch 'main' of github.com:colibie/envoy-mobile into java/quic…

22bc6bb

…TestServer Signed-off-by: Chidera Olibie <[email protected]>

Merge branch 'main' of github.com:colibie/envoy-mobile into java/quic…

cec798e

…TestServer Signed-off-by: Chidera Olibie <[email protected]>

move submodule to latest commit in main

1e98c4d

Signed-off-by: Chidera Olibie <[email protected]>

added direct response to test engine

8a6208f

Signed-off-by: Chidera Olibie <[email protected]>

Merge branch 'main' of github.com:colibie/envoy-mobile into java/quic…

bc01022

…TestServer

WIP

189e3e9

Signed-off-by: Chidera Olibie <[email protected]>

[wip]

7511986

Signed-off-by: Chidera Olibie <[email protected]>

add JVM test for the QuicTestServer

2b61716

Signed-off-by: Chidera Olibie <[email protected]>

wip

75f52ef

Signed-off-by: Chidera Olibie <[email protected]>

add QuicTestServer and its associated test

9004b8c

Signed-off-by: Chidera Olibie <[email protected]>

Merge branch 'main' of github.com:colibie/envoy-mobile into java/quic…

32401c4

…TestServer Signed-off-by: Chidera Olibie <[email protected]>

checkout to correct envoy version

4864676

Signed-off-by: Chidera Olibie <[email protected]>

Fix thread issue

69983dd

Signed-off-by: Chidera Olibie <[email protected]>

Fix thread issue

0789bec

Signed-off-by: Chidera Olibie <[email protected]>

nit fixes

c6ef82a

Signed-off-by: Chidera Olibie <[email protected]>

add linux jni header and nit changes

7aca613

Signed-off-by: Chidera Olibie <[email protected]>

add linux jni header and nit changes

79819e2

Signed-off-by: Chidera Olibie <[email protected]>

testing

ad9170b

fix PR comments and check test asan build

d09958c

Signed-off-by: Chidera Olibie <[email protected]>

ci test

4123d56

Signed-off-by: Chidera Olibie <[email protected]>

ci testing

cb3e22b

Signed-off-by: Chidera Olibie <[email protected]>

reverting cc_binary changes

9836d38

Signed-off-by: Chidera Olibie <[email protected]>

Merge branch 'main' of github.com:colibie/envoy-mobile into java/quic…

05c30c8

…TestServer

pull in updates

03c2053

Signed-off-by: Chidera Olibie <[email protected]>

Merge branch 'main' into cronvoy052

d8c2585

Signed-off-by: Charles Le Borgne <[email protected]>

carloseltuerto requested a review from buildbreaker January 5, 2022 21:25

carloseltuerto added 7 commits January 11, 2022 13:42

Merge branch 'main' into cronvoy052

be6bdfb

Signed-off-by: Charles Le Borgne <[email protected]>

Kick CI

29aabd1

Signed-off-by: Charles Le Borgne <[email protected]>

Remove logs

1b0ffc9

Signed-off-by: Charles Le Borgne <[email protected]>

Use port zero to avoid conflicts

16f14c9

Signed-off-by: Charles Le Borgne <[email protected]>

Try another port

fbfa612

Signed-off-by: Charles Le Borgne <[email protected]>

Desperate attempt with Manifest

9ccb763

Signed-off-by: Charles Le Borgne <[email protected]>

Update QuicTestServer BUILD file

2e8cdcf

Signed-off-by: Charles Le Borgne <[email protected]>

carloseltuerto added 3 commits January 13, 2022 22:56

Enable networking for CI

097f6f4

Signed-off-by: Charles Le Borgne <[email protected]>

Revert unwanted file

3373d94

Signed-off-by: Charles Le Borgne <[email protected]>

Kick CI

8b6e8f2

Signed-off-by: Charles Le Borgne <[email protected]>

colibie reviewed Jan 14, 2022

View reviewed changes

test/java/io/envoyproxy/envoymobile/engine/testing/QuicTestServerTest.java Show resolved Hide resolved

colibie reviewed Jan 14, 2022

View reviewed changes

colibie previously approved these changes Jan 14, 2022

View reviewed changes

carloseltuerto requested review from alyssawilk and RyanTheOptimist and removed request for goaway and buildbreaker January 15, 2022 12:01

RyanTheOptimist reviewed Jan 18, 2022

View reviewed changes

Addressed Ryan's comments.

1b4321e

Signed-off-by: Charles Le Borgne <[email protected]>

carloseltuerto dismissed colibie’s stale review via 1b4321e January 19, 2022 17:57

carloseltuerto added 2 commits January 19, 2022 18:00

Fix ASSERT put at the wrong place

6e998da

Signed-off-by: Charles Le Borgne <[email protected]>

Add comments to JNI interface

e6d6b26

Signed-off-by: Charles Le Borgne <[email protected]>

RyanTheOptimist approved these changes Jan 19, 2022

View reviewed changes

alyssawilk approved these changes Jan 20, 2022

View reviewed changes

alyssawilk merged commit 100a566 into envoyproxy:main Jan 20, 2022

carloseltuerto deleted the cronvoy052 branch February 15, 2022 19:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cloned QuicTestServer #1989

Cloned QuicTestServer #1989

carloseltuerto commented Dec 27, 2021 •

edited

Loading

lfpino commented Jan 13, 2022

colibie left a comment

RyanTheOptimist left a comment

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist Jan 18, 2022

carloseltuerto Jan 19, 2022

RyanTheOptimist left a comment


		public static final String getServerCertKey() { return KEY_USED; }

		public static long createMockCertVerifier() {

Cloned QuicTestServer #1989

Cloned QuicTestServer #1989

Conversation

carloseltuerto commented Dec 27, 2021 • edited Loading

lfpino commented Jan 13, 2022

colibie left a comment

Choose a reason for hiding this comment

RyanTheOptimist left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RyanTheOptimist left a comment

Choose a reason for hiding this comment

carloseltuerto commented Dec 27, 2021 •

edited

Loading