tooling: first pass at oncall tooling #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alyssa Wilk <[email protected]>
goaway
reviewed
Jan 24, 2022
| 'junr03': 'U79K0Q431', | ||
| 'RyanTheOptimist': 'U01SW3JC8GP', | ||
| 'goaway': 'U7TDPD3L2', | ||
| 'snowp': 'U93KTPQP6', |
There was a problem hiding this comment.
I think it would make sense to add buildbreaker, jpsim, and Augustyniak here - this is just for review reminders, right?
There was a problem hiding this comment.
cc @buildbreaker @jpsim @Augustyniak so when you eventually get slack pings from the "PR reminders" app, you know where they came from :-)
goaway
previously approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Thanks @alyssawilk! This sounds great. Suggested a few more names, but this sounds good as an initial setup to me either way.
Signed-off-by: Alyssa Wilk <[email protected]>
goaway
approved these changes
Jan 24, 2022
jpsim
added a commit
to jpsim/envoy-mobile
that referenced
this pull request
Feb 3, 2022
* origin/main: (21 commits) owners: adding charles (envoyproxy#2038) [OWNERS] Update Envoy Mobile owners (envoyproxy#2031) [deps] Update rules_android to a stable release URL (envoyproxy#2032) [json] Remove com_github_nlohmann_json override & patch (envoyproxy#2030) Enable the "received byte count" feature. (envoyproxy#2004) Run Kotlin macOS tests without EngFlow (envoyproxy#2018) final_intel: adding response flags (envoyproxy#2009) fix (envoyproxy#2025) stream intel: update kotlin public interface to align with swift (envoyproxy#2013) tls: update bundled root certificates (envoyproxy#2016) tooling: first pass at oncall tooling (envoyproxy#2014) test: Solve CI flakiness for test/java/org/chromium/net/urlconnection:urlconnection_test (envoyproxy#2007) envoy: 519774f742 (envoyproxy#2015) Default timestamp to -1 for envoy_final_stream_intel (envoyproxy#2006) QuicTestServer (envoyproxy#1989) bump boringssl to Envoy's version (envoyproxy#1999) docs: addding release notes (envoyproxy#2001) release: cutting the 0.4.5 release (envoyproxy#2000) Revert "bazel: change bazelisk for M1 support (envoyproxy#1966)" (envoyproxy#1998) Decompress even when `no-transform` is specified (envoyproxy#1995) ... Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copy/paste/edited from
https://github.com/envoyproxy/envoy/blob/main/.github/workflows/pr_notifier.yml
General functionality:
send daily reminders to folks listed as reviewers. Lyft folk: please let me know who else if any should be added
send on-call channel updates for PRs which are out-SLO (haven't been reviewed in 2 days, and aren't tagged as waiting)
Major differences from the Envoy tooling:
removed all the first-pass review and api review cruft
no nags for unassigned PRs - I think we'll want this at some point but I think most repo contributors have been assigning their own when the PR is ready, WDYT?