Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster manager: cluster activation after it failed because of secure transport socket not ready #13777

Closed
Shikugawa opened this issue Oct 27, 2020 · 3 comments
Closed

cluster manager: cluster activation after it failed because of secure transport socket not ready #13777

Shikugawa opened this issue Oct 27, 2020 · 3 comments
Assignees
@Shikugawa
Labels
area/cluster_manager area/sds SDS related stale stalebot believes this issue/PR has not been touched recently

Comments

@Shikugawa
Copy link
Member

Related with #13344.
In the current implementation, it doesn't keep warming if SDS based secret entity can't be extracted because of the existence of runtime feature flag. envoy.reloadable_features.cluster_keep_warming_no_secret_entity.
To remove this, we should have delayed activate behavior on clusterInit. I'm considering implementing with this approach.

  • If it failed to create secure transport socket factory after initial_fetch_timeout occurred, It doesn't change state from warming. When it was called, we should activate delayed callback which will activate the cluster by executing onClusterInit at regular intervals.

It is only proposal. So I'm glad to introduce other approaches. cc @htuch
@Shikugawa Shikugawa added the triage Issue requires triage label Oct 27, 2020
@yanavlasov yanavlasov added area/cluster_manager area/xds area/sds SDS related and removed triage Issue requires triage area/xds labels Oct 27, 2020
@lizan lizan added the no stalebot Disables stalebot from closing an issue label Oct 27, 2020
lizan pushed a commit that referenced this issue Oct 27, 2020
@Shikugawa
sds: keep warming when dynamic inserted cluster can't be extracted se…
e5a8c21 
…cret entity (#13344)

This PR highly depends on #12783. Changed to keep warming if dynamic inserted clusters (when initialize doesn't finished) failed to extract TLS certificate and certificate validation context. They shouldn't be indicated as ACTIVE cluster.
Risk Level: Mid
Testing: Unit
Docs Changes:
Release Notes: Added
Fixes #11120, future work: #13777

Signed-off-by: Shikugawa <[email protected]>
@Shikugawa
Copy link
Member Author

/assign @Shikugawa

lizan pushed a commit to lizan/envoy that referenced this issue Oct 30, 2020
@Shikugawa @lizan
sds: keep warming when dynamic inserted cluster can't be extracted se…
2be1c97 
…cret entity (envoyproxy#13344)

This PR highly depends on envoyproxy#12783. Changed to keep warming if dynamic inserted clusters (when initialize doesn't finished) failed to extract TLS certificate and certificate validation context. They shouldn't be indicated as ACTIVE cluster.
Risk Level: Mid
Testing: Unit
Docs Changes:
Release Notes: Added
Fixes envoyproxy#11120, future work: envoyproxy#13777

Signed-off-by: Shikugawa <[email protected]>
istio-testing pushed a commit to istio/envoy that referenced this issue Nov 2, 2020
@lizan @Shikugawa
Sds backport (#281)
4bb1cfe 
* cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783)

Signed-off-by: Shikugawa <[email protected]>

* sds: keep warming when dynamic inserted cluster can't be extracted secret entity (envoyproxy#13344)

This PR highly depends on envoyproxy#12783. Changed to keep warming if dynamic inserted clusters (when initialize doesn't finished) failed to extract TLS certificate and certificate validation context. They shouldn't be indicated as ACTIVE cluster.
Risk Level: Mid
Testing: Unit
Docs Changes:
Release Notes: Added
Fixes envoyproxy#11120, future work: envoyproxy#13777

Signed-off-by: Shikugawa <[email protected]>

Co-authored-by: Rei Shimizu <[email protected]>
@lizan lizan mentioned this issue Nov 12, 2020
Closed
@alyssawilk alyssawilk removed the no stalebot Disables stalebot from closing an issue label Oct 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Nov 7, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shikugawa Shikugawa

Labels
area/cluster_manager area/sds SDS related stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lizan @yanavlasov @Shikugawa @alyssawilk