cluster manager: avoid immediate activation for dynamic inserted cluster when initialize #12783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter when initialize Signed-off-by: Shikugawa <[email protected]>
|
@lizan for first pass |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
stale
bot
added
the
stale
|
/nostale |
stale
bot
removed
the
stale
Signed-off-by: Shikugawa <[email protected]>
Signed-off-by: Shikugawa <[email protected]>
JimmyCYJ
reviewed
Oct 6, 2020
lizan
previously approved these changes
Oct 14, 2020
There was a problem hiding this comment.
This LGTM, can you merge master? @mattklein123 for non-Tetrate pass.
|
Please merge main and I will take a look. /wait |
Signed-off-by: Shikugawa <[email protected]>
|
Merge main once #13598 merges. Thanks! /wait |
|
@mattklein123 FYI a |
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 17, 2020
* master: (22 commits) delay health checks until transport socket secrets are ready. (envoyproxy#13516) test, oauth2: Make sure config test runs field validation (envoyproxy#13496) [http] swap codec implementations to default new (envoyproxy#13579) wasm: update proxy-wasm-cpp-host (envoyproxy#13606) postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393) configs: Update configs v2 -> v3 (envoyproxy#13562) http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546) dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571) listener: add match all filter chain (envoyproxy#13449) fix mistakes in docstrings (envoyproxy#13603) ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269) cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) ext_authz: Avoid calling check multiple times (envoyproxy#13288) docs: Unexclude remaining configs from validation (envoyproxy#13534) build: update rules_rust to allow Rustc in RBE (envoyproxy#13595) docs: Update sphinxext.rediraffe (envoyproxy#13589) Deprecate moonjit support on Windows before beta (envoyproxy#13541) dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474) docs: add TLS stats to cluster stats doc (envoyproxy#13561) ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598) ... Signed-off-by: Michael Puncel <[email protected]>
|
FYI seeing some envoys stuck in |
this is when doing a hot restart |
|
Thanks @rgs1, it wouldn't surprise me if there was some bugs here. This code is complicated. If we need to revert we can. |
|
I'll do a bisect in a bit and confirm the offending commit. |
lizan
pushed a commit
that referenced
this pull request
Oct 27, 2020
…cret entity (#13344) This PR highly depends on #12783. Changed to keep warming if dynamic inserted clusters (when initialize doesn't finished) failed to extract TLS certificate and certificate validation context. They shouldn't be indicated as ACTIVE cluster. Risk Level: Mid Testing: Unit Docs Changes: Release Notes: Added Fixes #11120, future work: #13777 Signed-off-by: Shikugawa <[email protected]>
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Oct 30, 2020
…ter when initialize (envoyproxy#12783) Signed-off-by: Shikugawa <[email protected]>
lizan
pushed a commit
to lizan/envoy
that referenced
this pull request
Oct 30, 2020
…cret entity (envoyproxy#13344) This PR highly depends on envoyproxy#12783. Changed to keep warming if dynamic inserted clusters (when initialize doesn't finished) failed to extract TLS certificate and certificate validation context. They shouldn't be indicated as ACTIVE cluster. Risk Level: Mid Testing: Unit Docs Changes: Release Notes: Added Fixes envoyproxy#11120, future work: envoyproxy#13777 Signed-off-by: Shikugawa <[email protected]>
Merged
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Nov 2, 2020
* cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) Signed-off-by: Shikugawa <[email protected]> * sds: keep warming when dynamic inserted cluster can't be extracted secret entity (envoyproxy#13344) This PR highly depends on envoyproxy#12783. Changed to keep warming if dynamic inserted clusters (when initialize doesn't finished) failed to extract TLS certificate and certificate validation context. They shouldn't be indicated as ACTIVE cluster. Risk Level: Mid Testing: Unit Docs Changes: Release Notes: Added Fixes envoyproxy#11120, future work: envoyproxy#13777 Signed-off-by: Shikugawa <[email protected]> Co-authored-by: Rei Shimizu <[email protected]>
lambdai
pushed a commit
to lambdai/envoy-dai
that referenced
this pull request
Nov 10, 2020
…ter when initialize (envoyproxy#12783) Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Yuchen Dai <[email protected]>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Nov 11, 2020
* cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783) Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Yuchen Dai <[email protected]> * cluster: unstuck cluster manager when update the initializing cluster (envoyproxy#13875) Signed-off-by: Yuchen Dai <[email protected]> Co-authored-by: Rei Shimizu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: To resolve #12670. This commit changes the cluster state change. In previous implementation, dynamically inserted cluster when initialization should be active immediately. This patch changes, from active immediately to warming -> active when initialization.
Additional Description:
Risk Level: Mid (core behavior change)
Testing: Unit
Docs Changes: Needed
Release Notes: Needed
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]